Skip to content

Commit

Permalink
Suppress flaky update-deps failures for any win32 files
Browse files Browse the repository at this point in the history
win32/win32.o was also unstable:
https://github.com/ruby/ruby/actions/runs/5628655900/job/15252762821?pr=8107

At this point, any win32 files seem suspicious. Let's just ignore all
such files.
  • Loading branch information
k0kubun committed Jul 22, 2023
1 parent 11deab7 commit 7cecd15
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions tool/update-deps
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,8 @@ FILES_SAME_NAME_TOP = %w[
]

# Files that may or may not exist on CI for some reason.
# They are probably missing dependencies.
UNSTABLE_FILES = %w[
win32/file.o
]
# Windows build generally seems to have missing dependencies.
UNSTABLE_FILES = %r{\Awin32/[^/]+\.o\z}

# Other source files exist in the source directory.

Expand Down Expand Up @@ -236,7 +234,9 @@ def in_makefile(target, source)
else source2 = "$(top_srcdir)/#{source}"
end
["#{File.dirname(target)}/depend", target2, source2]
when *UNSTABLE_FILES
# Files that may or may not exist on CI for some reason.
# Windows build generally seems to have missing dependencies.
when UNSTABLE_FILES
warn "warning: ignoring: #{target}"
else
raise "unexpected target: #{target}"
Expand Down

0 comments on commit 7cecd15

Please sign in to comment.