Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spec): marshal OAuthFlow's scopes as an empty map if nil #87

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

wI2L
Copy link
Owner

@wI2L wI2L commented Aug 18, 2022

The field is required by the spec, and may be empty.

closes #86

The field is required by the spec, and may be empty.

closes #86
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #87 (c373840) into master (1f5d47b) will decrease coverage by 0.39%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   94.93%   94.54%   -0.40%     
==========================================
  Files           7        7              
  Lines         967      971       +4     
==========================================
  Hits          918      918              
- Misses         33       37       +4     
  Partials       16       16              
Impacted Files Coverage Δ
openapi/spec.go 74.41% <0.00%> (-7.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@jpedrofontes jpedrofontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required field is maintained in the output yaml. Good job

@wI2L wI2L merged commit 80afc14 into master Sep 6, 2022
@wI2L wI2L deleted the oauth-scopes-marshaling branch September 6, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No scopes unavailable in OAuth2 flow
2 participants