-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XCM Doc Restructure: Covering pallet-xcm #4578
Conversation
docs/learn/learn-xcm-pallet.md
Outdated
- **Transferring** or **reserving** an asset implies the movement of funds from one authority to | ||
another, in this case, from the Origin of the sender's chain and into the sovereign account (who | ||
will ultimately benefit from the assets) on the destination chain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not really clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Transferring or reserving an asset implies that equivalent assets (i.e, native currency) are withdrawn from the ownership of the current origin and deposited into the sovereign account on the destination chain. Unlike teleporting an asset, it is not destroyed, rather a trusted entity is used (i.e., Statemint on Polkadot) to reserve the assets, wherein the sovereign account on the destination chain obtains ownership of them.
Is this clearer? Might be worth creating a diagram for to show the difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the term equivalent asset defined anywhere else other than here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under the xcm-format
repo, it's used a few times: https://github.com/paritytech/xcm-format#transferreserveasset
Is it worth noting that this asset is representative of the origin chain? i.e, DOT becoming known as "wrapped" DOT on the destination chain, or is that inaccurate?
Just a sidenote - the goal of this portion is to cover some concepts that will be covered in more depth later in the wiki, (example: Trader is mentioned but not explained in depth quite yet). Generally, I think it's good to showcase pallet-xcm initially as an example of where to start when looking into the more technical aspects of understanding XCM. |
@KiChjang @joepetrowski Thank you both for the review! If it looks good, I think it would be ready to polish slightly and merge. In subsequent XCM sections, more content and detail can be provided. |
As part of issue #4541, this PR covers and documents
pallet-xcm
:TODO
pallet-xcm
doespallet-xcm
handles feespallet-xcm
(and what they do)pallet-xcm
defines interfaces forXcmConfig