Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Fix Bikeshed Warnings #1218

Merged
merged 24 commits into from
Feb 22, 2018
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sections/browsers.include
Original file line number Diff line number Diff line change
Expand Up @@ -2046,12 +2046,12 @@ concepts including Origin, Browsing Context, Navigating between pages
<a>sandboxed <code>document.domain</code> browsing context flag</a> set, then throw a
"{{SecurityError}}" {{DOMException}}.
1. Let <var>effectiveDomain</var> be this <code>Document</code>'s <a>origin</a>'s
<a data-lt="concept-origin-effective-domain">effective domain</span>.
<a>effective domain</a>.
1. If <var>effectiveDomain</var> is null, then throw a "{{SecurityError}}" {{DOMException}}.
1. If the given value <span data-x="is a registrable domain suffix of or is equal to">is not
a registrable domain suffix of and is not equal to</span> <var>effectiveDomain</var>
throw a "{{SecurityError}}" {{DOMException}}.
1. Set <var>origin</var>'s <a lt="origin domain">domain</a> to to the result of <a data-lt="host parser">parsing</span>
1. Set <var>origin</var>'s <a lt="origin domain">domain</a> to to the result of <a data-lt="host parser">parsing</a>
the given value.</p>.

<p class="note">The {{Document/domain|document.domain}} attribute is used to enable pages on
Expand Down
4 changes: 2 additions & 2 deletions sections/changes.include
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ and the <a href="https://www.w3.org/TR/2017/WD-html53-20171214/">HTML 5.3 First
<dd>Substantive change. Fixed <a href="https://github.com/w3c/html/issues/890">issue 890</a></dd>
<dt><a href="https://github.com/w3c/html/pull/1123">Removing magic alignment for <code>dialog</code> element</a></dt>
<dd>Removed due to lack of implementation. Fixed <a href="https://github.com/w3c/html/issues/1108">issue 1108</a></dd>
<dt><a href="https://github.com/w3c/html/pull/tbd">nonce now operate on the <a href="#cryptographicnonce">[[<span>CryptographicNonce</span>]]</a></dt>
<dt><a href="https://github.com/w3c/html/pull/tbd">nonce now uses</a> the <a href="#cryptographicnonce">[[<span>CryptographicNonce</span>]]</a></dt>
<dd><a href="https://github.com/w3c/html/issues/1121">Hide `nonce` content attribute</a></dd>
<dt><a href="https://github.com/w3c/html/pull/1152">Removed section on <code>anchor-points</code></a></dt>
<dd>Substantive change. Fixed <a href="https://github.com/w3c/html/issues/1104">issue 1104</a></dd>
<dt><a href="https://github.com/w3c/html/pull/1167">Added <{media/disableRemotePlayback}> to the {{HTMLMediaElement}} interface</a></dt>
<dt><a href="https://github.com/w3c/html/pull/1167">Added <code>disableRemotePlayback</code> to the <code>HTMLMediaElement</code> interface</a></dt>
<dd>Fixed <a href="https://github.com/w3c/html/issues/1047">issue 1047</a></dd>
<dt><a href="https://github.com/w3c/html/pull/1177">Cleaned up the Fetch sections</a> to apply the <a>cryptographic nonce metadata</a>,
and the <{script/integrity}> attribute from [[SRI]]</dt>
Expand Down
2 changes: 0 additions & 2 deletions sections/elements.include
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,6 @@
<{link/rel}>;
<{link/media}>;
<{link/referrerpolicy}>;
<{link/nonce}>;
<{link/hreflang}>;
<{link/type}>;
<{link/sizes}></td>
Expand Down Expand Up @@ -1256,7 +1255,6 @@
<td>varies*</td>
<td><a>globals</a>;
<{style/media}>;
<{style/nonce}>;
<{style/type}></td>
<td>{{HTMLStyleElement}}</td>
</tr>
Expand Down
14 changes: 7 additions & 7 deletions sections/infrastructure.include
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ It covers
rule. In particular, a <a>valid MIME type</a> may include MIME type parameters. [[!HTTP]]

A string is a
<a>valid MIME type with no parameters</a>
<dfn export>valid MIME type with no parameters</dfn>
if it matches the <code>[=media-type=]</code> rule, but does not contain any U+003B SEMICOLON
characters (;). In other words, if it consists only of a type and subtype, with no MIME Type
parameters. [[!HTTP]]
Expand Down Expand Up @@ -3316,7 +3316,7 @@ It covers
the document.

The <dfn export>rules for parsing a hash-name reference</dfn> to an element of type <var>type</var>,
given a context node <var>scope</var>, are as follows:
given a context node <var ignore=''>scope</var>, are as follows:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since scope is not used in the algorithm, it makes more sense just to remove it, or check whether something is missing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


1. If the string being parsed does not contain a U+0023 NUMBER SIGN character, or if the first
such character in the string is the last character in the string, then return null and abort
Expand Down Expand Up @@ -3851,7 +3851,7 @@ It covers
</ol>
</div>

<h4 id="nonce-attributes">Nonce attributes</h4>
<h4 id="nonce-attributes"><dfn>Nonce</dfn> attributes</h4>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't nonce defined just below? Why the extra dfn?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I don't add that dfn, I get LINK ERROR: No 'dfn' refs found for 'nonce'.<a data-link-type="dfn" data-lt="nonce">nonce</a>
This may be down to me not fully understanding bikeshed cross references.


<p>A <dfn element-attr for="global">nonce</dfn> content attribute represents a
cryptographic nonce ("number used once") which can be used by <a>Content Security Policy</a>
Expand Down Expand Up @@ -3887,7 +3887,7 @@ interface NoncedElement {
<p>Whenever a {{NoncedElement}}'s <a>nonce</a> attribute is
set or changed, set this element's <a href="#cryptographicnonce">[[<span>CryptographicNonce<span>]]</a> to the given value.</p>

<p>Whenever a {{NoncedElement}} <a>becomes browsing-context connected</a>, the
<p>Whenever a {{NoncedElement}} becomes connected to a <a>browsing context</a>, the
user agent must executing the following steps on the <var>element</var>:</p>

<ol>
Expand All @@ -3896,7 +3896,7 @@ interface NoncedElement {
<li>
<p>If [=response/CSP list=] <a>contains a header-delivered Content Security Policy</a>, and
<var>element</var> has a <a>nonce</a> content attribute
<var>attr</var> whose value is not the empty string, then:</p>
<var ignore=''>attr</var> whose value is not the empty string, then:</p>

<ol>
<li><p><a>Set an attribute value</a> for
Expand All @@ -3908,7 +3908,7 @@ interface NoncedElement {

<p class="note">As each {{Document}}'s [=response/CSP list=] is append-only, user agents can optimize away the <a>contains a header-delivered
Content Security Policy</a> check by, for example, holding a flag on the {{Document}},
set during <a>Document initialization</a>.</p>
set during Document initialization.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the reference be to https://w3c.github.io/html/browsers.html#initializing-a-new-document-object - maybe adding an alternate term there would be better.

or set when <a>initializing a new document object</a> ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


<p>The <a>cloning steps</a> for elements that implement
{{NoncedElement}} must set the <a href="#cryptographicnonce">[[<span>CryptographicNonce</span>]]</a> slot on the copy
Expand Down Expand Up @@ -5302,7 +5302,7 @@ o.myself = o;</pre>

<p class="example"><code>messagePort.postMessage()</code>
uses this pair of abstract operations, as the destination Realm is not known until the
<code>MessagePort</code> <a>has been shipped</a>.</p>
<code>MessagePort</code> <dfn><a href="https://www.w3.org/TR/webmessaging/#has-been-shipped">has been shipped</a>.</p>

: <a>StructuredSerialize</a>
: <a>StructuredSerializeForStorage</a>
Expand Down
4 changes: 2 additions & 2 deletions sections/rendering.include
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@
Rendering {#rendering}
=========

*User agents are not required to present HTML documents in any particular way. However, this
User agents are not required to present HTML documents in any particular way. However, this
section provides a set of suggestions for rendering HTML documents that, if followed, are likely
to lead to a user experience that closely resembles the experience intended by the documents'
authors. So as to avoid confusion regarding the normativity of this section, "must" has not been
used. Instead, the term "expected" is used to indicate behavior that will lead to this experience.
For the purposes of conformance for user agents designated as
[=supporting the suggested default rendering=], the term "expected" in this section has the same
conformance implications as "must".*
conformance implications as "must".

## Introduction ## {#rendering-introduction}

Expand Down
4 changes: 2 additions & 2 deletions sections/semantics-forms.include
Original file line number Diff line number Diff line change
Expand Up @@ -8633,7 +8633,7 @@ You cannot submit this form when the field is incorrect.</samp></pre>
<a for="progress">current value</a> relative to the <a for="progress">maximum value</a>,
e.g. by filling an appropriate fraction of the widget in a contrasting color.

<h5 id="determinate-progress-bar">Determinate progress bars</h5>
<h5 id="sec-determinate-progress-bar">Determinate progress bars</h5>

Authors are encouraged to include the current value and the <a for="progress">maximum value</a> inline as text
inside the element, so that the progress is made available to users of legacy user agents.
Expand Down Expand Up @@ -8679,7 +8679,7 @@ You cannot submit this form when the field is incorrect.</samp></pre>
The {{HTMLProgressElement/position}} IDL attribute must return the
result of dividing the <a for="progress">current value</a> by the <a for="progress">maximum value</a>.

<h5 id="indeterminate-progress-bar">Indeterminate progress bars</h5>
<h5 id="sec-indeterminate-progress-bar">Indeterminate progress bars</h5>

<div class="example">
Here is a snippet of a Web application that shows whether a task is complete:
Expand Down
4 changes: 2 additions & 2 deletions sections/semantics-grouping-content.include
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
The <{p}> element should not be used when a more specific element, such as a list, is more appropriate.

<div class="note">
Many elements whose typical <a>rendering</a> is a block cannot be children of <{p}> elements,
because when the parser finds them it automatically closes the <{p}> element - effectively inserting a <code>&lt;/p&gt;</code> tag.
Many elements whose typical rendering is a block, cannot be children of <{p}> elements.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the comma too, but that's pretty editorial...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

When the parser finds them it automatically closes the <{p}> element - effectively inserting a <code>&lt;/p&gt;</code> tag.
This includes lists, tables, <a>heading content</a>, most <a>sectioning roots</a> and <a>sectioning content</a>,
and <{form}>, <{fieldset}> and <{legend}> elements.
</div>
Expand Down
8 changes: 4 additions & 4 deletions sections/semantics-scriptings.include
Original file line number Diff line number Diff line change
Expand Up @@ -431,11 +431,11 @@

Otherwise, if the <{script}> element has a <{script/type}> attribute, let
<var>the script block's type string</var> for this <{script}> element be the value of that
attribute after <a>stripping leading and trailing whitespace</a>.
attribute after <a>stripping leading and trailing white space</a>.

Otherwise, the element has a non-empty <{script/language}> attribute; let
<var>the script block's type string</var> for this <{script}> element be the
concatenation of the string "<var>text/</var>" followed by the value of the <{script/language}> attribute.
concatenation of the string "<code>text/</code>" followed by the value of the <{script/language}> attribute.

<p class="note">The <{script/language}> attribute is never conforming, and is always ignored
if there is a <{script/type}> attribute present.</p>
Expand Down Expand Up @@ -494,7 +494,7 @@
internal slot's value.
16. If the <{script}> element has an <{script/integrity}> attribute, then let <var>integrity metadata</var> be that attribute's value.
Otherwise, let <var>integrity metadata</var> be the empty string.
17. Let <var>parser metadata</var> be "<code>parser-inserted</code>" if the <{script}> element has been flagged
17. Let <var ignore=''>parser metadata</var> be "<code>parser-inserted</code>" if the <{script}> element has been flagged
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ignore? Shouldn't the mention in the step below refer to the var?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

as "[=parser-inserted=]", and "`not parser-inserted`" otherwise.
18. Let options be a set of <a>script fetch options</a> whose <a>cryptographic nonce metadata</a> is
cryptographic nonce, <a>integrity metadata</a> is integrity metadata,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here, the second "integrity metadata" should be a var - and the last "parser metadata" too, no?

Expand All @@ -517,7 +517,7 @@
<dl class="switch">
<dt>`"classic"`</dt>
<dd><a>Fetch a classic script</a> given <var>url</var>, <var>settings object</var>,
<var>options</var>, <var>classic script CORS setting</var>, and
<var>options</var>, <var ignore=''>classic script CORS setting</var>, and
<var>encoding</var>.

<dt><code>"module"</code></dt>
Expand Down
2 changes: 1 addition & 1 deletion sections/syntax.include
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
<dfn>Tags</dfn> are used to delimit the start and end of elements in the markup. [=Raw text=],
[=escapable raw text=], and [=normal elements=] have a [=start tag=] to indicate where they begin,
and an [=end tag=] to indicate where they end. The start and end tags of certain
[=normal elements=] can be [=omitted=], as described below in the section on [=optional tags=].
[=normal elements=] can be omitted, as described in the section on [=omitted|optional tags=].
Those that cannot be omitted must not be omitted. [=Void elements=] only have a start tag; end
tags must not be specified for [=void elements=]. [=Foreign elements=] must either have a start
tag and an end tag, or a start tag that is marked as self-closing, in which case they must not
Expand Down
10 changes: 5 additions & 5 deletions sections/webappapis.include
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ APIs for Web APplications. This is a bit of a grab-bag

<p>The <dfn>default classic script fetch options</dfn> are a set of<a>script fetch options</a>
whose <a>cryptographic nonce</a> is the empty string, <a>integrity metadata</a> is the empty string,
<a>parser metadata</span> is "<code>not-parser-inserted</code>", <a>credentials mode</a> is "<code>omit</code>",
<a>parser metadata</a> is "<code>not-parser-inserted</code>", <a>credentials mode</a> is "<code>omit</code>",
and <a>referrer policy</a> is the empty string.</p>

<p>Given a <a>request</a> <var>request</var> and <a>script fetch options</a> <var>options</var>, we define:</p>
Expand Down Expand Up @@ -321,7 +321,7 @@ APIs for Web APplications. This is a bit of a grab-bag
11. Asynchronously complete this algorithm with <var>script</var>.

To <dfn>fetch a classic worker script</dfn> given a <var>url</var>, a <var>fetch client settings object</var>,
a <var>destination</var>, and a <var>script settings object</var>, run these steps. The algorithm will
a <var>destination</var>, and a <var ignore=''>script settings object</var>, run these steps. The algorithm will
asynchronously complete with either null (on failure) or a new <a>classic script</a>
(on success).

Expand All @@ -332,7 +332,7 @@ APIs for Web APplications. This is a bit of a grab-bag
<a>use-URL-credentials flag</a> is set.
2. If the caller specified custom steps to <a>perform
the fetch</a>, perform them on <var>request</var>, with the <a>is top-level</a> flag set. Return from this algorithm,
and when the custom <a>perform the fetch</span> steps
and when the custom <a>perform the fetch</a> steps
complete with <a>response</a> <var>response</var>, run the
remaining steps.
<p>Otherwise, <a>fetch</a> <var>request</var>.</p>
Expand Down Expand Up @@ -360,7 +360,7 @@ APIs for Web APplications. This is a bit of a grab-bag
2. If <var>module map settings object</var> is not given, let it be <var>fetch client settings
object</var>.
3. <a>Fetch a single module script</a> given <var>url</var>, <var>credentials mode</var>,
<var>cryptographic nonce</var>, <var>parser state</var>, <var>destination</var>, and
<var>cryptographic nonce</var>, <var ignore=''>parser state</var>, <var>destination</var>, and
<var>module map settings object</var>. If the caller of this algorithm specified custom
<a>set up the request</a> or <a>process the response</a> steps, pass those along while
<a>fetching a single module script</a>.
Expand Down Expand Up @@ -418,7 +418,7 @@ APIs for Web APplications. This is a bit of a grab-bag

To <dfn lt="fetching a single module script|fetch a single module script">fetch a single module script</dfn>,
given a <var>url</var>, a <var>fetch client settings object</var>, a <var>destination</var>, some <var>options</var>,
a <var>module map settings object</var>, a <var>referrer</var>, and a <var>top-level module fetch</var> flag, run these steps.
a <var>module map settings object</var>, a <var>referrer</var>, and a <var ignore=''>top-level module fetch</var> flag, run these steps.
The algorithm will asynchronously complete with either null (on failure) or a <a>module script</a> (on success).

1. Let <var>module map</var> be <var>settings object</var>'s <a>module map</a>.
Expand Down
1 change: 1 addition & 0 deletions single-page.bs
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,7 @@ urlPrefix: https://tc39.github.io/ecma262/#; type: dfn; spec: ECMA-262
text: RunJobs
text: running JavaScript execution context; url: running-execution-context
text: SameValue
text: Script Record; url: script-records
text: ScriptEvaluation; url: runtime-semantics-scriptevaluation
text: Source Text Module Record; url: source-text-module-records
text: Strict Equality Comparison
Expand Down