-
Notifications
You must be signed in to change notification settings - Fork 544
Fix Bikeshed Warnings #1218
Fix Bikeshed Warnings #1218
Changes from 19 commits
cddb992
d1142f6
c650468
80beff2
f7aeb10
ab088cf
3f69714
19639b8
191b2cd
bd2f439
011610d
83f34f1
2fecb8a
e05baa8
0c20c2d
0a68b4b
1812625
6277a62
519387b
c12b1d8
2dd00f4
b458bc9
d899a71
7faa967
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -110,7 +110,7 @@ It covers | |
rule. In particular, a <a>valid MIME type</a> may include MIME type parameters. [[!HTTP]] | ||
|
||
A string is a | ||
<a>valid MIME type with no parameters</a> | ||
<dfn export>valid MIME type with no parameters</dfn> | ||
if it matches the <code>[=media-type=]</code> rule, but does not contain any U+003B SEMICOLON | ||
characters (;). In other words, if it consists only of a type and subtype, with no MIME Type | ||
parameters. [[!HTTP]] | ||
|
@@ -3316,7 +3316,7 @@ It covers | |
the document. | ||
|
||
The <dfn export>rules for parsing a hash-name reference</dfn> to an element of type <var>type</var>, | ||
given a context node <var>scope</var>, are as follows: | ||
given a context node <var ignore=''>scope</var>, are as follows: | ||
|
||
1. If the string being parsed does not contain a U+0023 NUMBER SIGN character, or if the first | ||
such character in the string is the last character in the string, then return null and abort | ||
|
@@ -3851,7 +3851,7 @@ It covers | |
</ol> | ||
</div> | ||
|
||
<h4 id="nonce-attributes">Nonce attributes</h4> | ||
<h4 id="nonce-attributes"><dfn>Nonce</dfn> attributes</h4> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't nonce defined just below? Why the extra There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If I don't add that dfn, I get |
||
|
||
<p>A <dfn element-attr for="global">nonce</dfn> content attribute represents a | ||
cryptographic nonce ("number used once") which can be used by <a>Content Security Policy</a> | ||
|
@@ -3887,7 +3887,7 @@ interface NoncedElement { | |
<p>Whenever a {{NoncedElement}}'s <a>nonce</a> attribute is | ||
set or changed, set this element's <a href="#cryptographicnonce">[[<span>CryptographicNonce<span>]]</a> to the given value.</p> | ||
|
||
<p>Whenever a {{NoncedElement}} <a>becomes browsing-context connected</a>, the | ||
<p>Whenever a {{NoncedElement}} becomes connected to a <a>browsing context</a>, the | ||
user agent must executing the following steps on the <var>element</var>:</p> | ||
|
||
<ol> | ||
|
@@ -3896,7 +3896,7 @@ interface NoncedElement { | |
<li> | ||
<p>If [=response/CSP list=] <a>contains a header-delivered Content Security Policy</a>, and | ||
<var>element</var> has a <a>nonce</a> content attribute | ||
<var>attr</var> whose value is not the empty string, then:</p> | ||
<var ignore=''>attr</var> whose value is not the empty string, then:</p> | ||
|
||
<ol> | ||
<li><p><a>Set an attribute value</a> for | ||
|
@@ -3908,7 +3908,7 @@ interface NoncedElement { | |
|
||
<p class="note">As each {{Document}}'s [=response/CSP list=] is append-only, user agents can optimize away the <a>contains a header-delivered | ||
Content Security Policy</a> check by, for example, holding a flag on the {{Document}}, | ||
set during <a>Document initialization</a>.</p> | ||
set during Document initialization.</p> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should the reference be to https://w3c.github.io/html/browsers.html#initializing-a-new-document-object - maybe adding an alternate term there would be better. or There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
|
||
<p>The <a>cloning steps</a> for elements that implement | ||
{{NoncedElement}} must set the <a href="#cryptographicnonce">[[<span>CryptographicNonce</span>]]</a> slot on the copy | ||
|
@@ -5302,7 +5302,7 @@ o.myself = o;</pre> | |
|
||
<p class="example"><code>messagePort.postMessage()</code> | ||
uses this pair of abstract operations, as the destination Realm is not known until the | ||
<code>MessagePort</code> <a>has been shipped</a>.</p> | ||
<code>MessagePort</code> <dfn><a href="https://www.w3.org/TR/webmessaging/#has-been-shipped">has been shipped</a>.</p> | ||
|
||
: <a>StructuredSerialize</a> | ||
: <a>StructuredSerializeForStorage</a> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,8 +42,8 @@ | |
The <{p}> element should not be used when a more specific element, such as a list, is more appropriate. | ||
|
||
<div class="note"> | ||
Many elements whose typical <a>rendering</a> is a block cannot be children of <{p}> elements, | ||
because when the parser finds them it automatically closes the <{p}> element - effectively inserting a <code></p></code> tag. | ||
Many elements whose typical rendering is a block, cannot be children of <{p}> elements. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would remove the comma too, but that's pretty editorial... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
When the parser finds them it automatically closes the <{p}> element - effectively inserting a <code></p></code> tag. | ||
This includes lists, tables, <a>heading content</a>, most <a>sectioning roots</a> and <a>sectioning content</a>, | ||
and <{form}>, <{fieldset}> and <{legend}> elements. | ||
</div> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -431,11 +431,11 @@ | |
|
||
Otherwise, if the <{script}> element has a <{script/type}> attribute, let | ||
<var>the script block's type string</var> for this <{script}> element be the value of that | ||
attribute after <a>stripping leading and trailing whitespace</a>. | ||
attribute after <a>stripping leading and trailing white space</a>. | ||
|
||
Otherwise, the element has a non-empty <{script/language}> attribute; let | ||
<var>the script block's type string</var> for this <{script}> element be the | ||
concatenation of the string "<var>text/</var>" followed by the value of the <{script/language}> attribute. | ||
concatenation of the string "<code>text/</code>" followed by the value of the <{script/language}> attribute. | ||
|
||
<p class="note">The <{script/language}> attribute is never conforming, and is always ignored | ||
if there is a <{script/type}> attribute present.</p> | ||
|
@@ -494,7 +494,7 @@ | |
internal slot's value. | ||
16. If the <{script}> element has an <{script/integrity}> attribute, then let <var>integrity metadata</var> be that attribute's value. | ||
Otherwise, let <var>integrity metadata</var> be the empty string. | ||
17. Let <var>parser metadata</var> be "<code>parser-inserted</code>" if the <{script}> element has been flagged | ||
17. Let <var ignore=''>parser metadata</var> be "<code>parser-inserted</code>" if the <{script}> element has been flagged | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why ignore? Shouldn't the mention in the step below refer to the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
as "[=parser-inserted=]", and "`not parser-inserted`" otherwise. | ||
18. Let options be a set of <a>script fetch options</a> whose <a>cryptographic nonce metadata</a> is | ||
cryptographic nonce, <a>integrity metadata</a> is integrity metadata, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. here, the second "integrity metadata" should be a |
||
|
@@ -517,7 +517,7 @@ | |
<dl class="switch"> | ||
<dt>`"classic"`</dt> | ||
<dd><a>Fetch a classic script</a> given <var>url</var>, <var>settings object</var>, | ||
<var>options</var>, <var>classic script CORS setting</var>, and | ||
<var>options</var>, <var ignore=''>classic script CORS setting</var>, and | ||
<var>encoding</var>. | ||
|
||
<dt><code>"module"</code></dt> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since
scope
is not used in the algorithm, it makes more sense just to remove it, or check whether something is missing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.