Fix Bikeshed Warnings #1218
Fix Bikeshed Warnings #1218
Conversation
WARNING: The following (probably auto-generated) link is illegally nested in another link: `<a data-link-type="idl" href="#htmlmediaelement" id="ref-for-htmlmediaelement⑥" data-silently-dedup="">HTMLMediaElement</a>` Re #1215
This was originally added by #387 in response to #186 and was ported over from whatwg/html@882803c We currently don't have a `style/nonce` nor `script/nonce`- neither do WHATWG. `nonce` is already covered by `global`. * Re whatwg/html#2373 * Re https://github.com/whatwg/html/pull/2373/files#r117354683 * Fixes #1215
|
This takes us down to 29 errors (from 50). I can't do any more because I don't understand bikeshed well enough. |
|
reviewing. Expect to be done Wednesday... |
| @@ -494,7 +494,7 @@ | |||
| internal slot's value. | |||
| 16. If the <{script}> element has an <{script/integrity}> attribute, then let <var>integrity metadata</var> be that attribute's value. | |||
| Otherwise, let <var>integrity metadata</var> be the empty string. | |||
| 17. Let <var>parser metadata</var> be "<code>parser-inserted</code>" if the <{script}> element has been flagged | |||
| 17. Let <var ignore=''>parser metadata</var> be "<code>parser-inserted</code>" if the <{script}> element has been flagged | |||
There was a problem hiding this comment.
why ignore? Shouldn't the mention in the step below refer to the var?
| @@ -494,7 +494,7 @@ | |||
| internal slot's value. | |||
| 16. If the <{script}> element has an <{script/integrity}> attribute, then let <var>integrity metadata</var> be that attribute's value. | |||
| Otherwise, let <var>integrity metadata</var> be the empty string. | |||
| 17. Let <var>parser metadata</var> be "<code>parser-inserted</code>" if the <{script}> element has been flagged | |||
| 17. Let <var ignore=''>parser metadata</var> be "<code>parser-inserted</code>" if the <{script}> element has been flagged | |||
| as "[=parser-inserted=]", and "`not parser-inserted`" otherwise. | |||
| 18. Let options be a set of <a>script fetch options</a> whose <a>cryptographic nonce metadata</a> is | |||
| cryptographic nonce, <a>integrity metadata</a> is integrity metadata, | |||
There was a problem hiding this comment.
here, the second "integrity metadata" should be a var - and the last "parser metadata" too, no?
| @@ -42,8 +42,8 @@ | |||
| The <{p}> element should not be used when a more specific element, such as a list, is more appropriate. | |||
|
|
|||
| <div class="note"> | |||
| Many elements whose typical <a>rendering</a> is a block cannot be children of <{p}> elements, | |||
| because when the parser finds them it automatically closes the <{p}> element - effectively inserting a <code></p></code> tag. | |||
| Many elements whose typical rendering is a block, cannot be children of <{p}> elements. | |||
There was a problem hiding this comment.
I would remove the comma too, but that's pretty editorial...
sections/infrastructure.include
Outdated
| @@ -3316,7 +3316,7 @@ It covers | |||
| the document. | |||
|
|
|||
| The <dfn export>rules for parsing a hash-name reference</dfn> to an element of type <var>type</var>, | |||
| given a context node <var>scope</var>, are as follows: | |||
| given a context node <var ignore=''>scope</var>, are as follows: | |||
There was a problem hiding this comment.
since scope is not used in the algorithm, it makes more sense just to remove it, or check whether something is missing.
| @@ -3851,7 +3851,7 @@ It covers | |||
| </ol> | |||
| </div> | |||
|
|
|||
| <h4 id="nonce-attributes">Nonce attributes</h4> | |||
| <h4 id="nonce-attributes"><dfn>Nonce</dfn> attributes</h4> | |||
There was a problem hiding this comment.
Isn't nonce defined just below? Why the extra dfn?
There was a problem hiding this comment.
If I don't add that dfn, I get LINK ERROR: No 'dfn' refs found for 'nonce'.<a data-link-type="dfn" data-lt="nonce">nonce</a>
This may be down to me not fully understanding bikeshed cross references.
sections/infrastructure.include
Outdated
| @@ -3908,7 +3908,7 @@ interface NoncedElement { | |||
|
|
|||
| <p class="note">As each {{Document}}'s [=response/CSP list=] is append-only, user agents can optimize away the <a>contains a header-delivered | |||
| Content Security Policy</a> check by, for example, holding a flag on the {{Document}}, | |||
| set during <a>Document initialization</a>.</p> | |||
| set during Document initialization.</p> | |||
There was a problem hiding this comment.
Should the reference be to https://w3c.github.io/html/browsers.html#initializing-a-new-document-object - maybe adding an alternate term there would be better.
or set when <a>initializing a new document object</a> ?
Fixes #1215 - commit to this branch and tick them off in that issue.