Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encryption scheme query support #457

Merged
merged 13 commits into from
Dec 11, 2019

Conversation

joeyparrish
Copy link
Member

@joeyparrish joeyparrish commented Nov 12, 2019

Closes #391


Preview | Diff

shaka-bot pushed a commit to shaka-project/shaka-player that referenced this pull request Nov 22, 2019
Note that the encryptionScheme field isn't being used by Shaka Player
yet, but that this will enable us to experiment with it ahead of the
full launch of the feature in browsers.

See also:
 - https://wicg.github.io/encrypted-media-encryption-scheme/
 - WICG/encrypted-media-encryption-scheme#13
 - w3c/encrypted-media#457

Change-Id: I9e8c2b6ce4ce3f4fe634fa4164669c69959e7fde
Copy link
Contributor

@gregwfreedman gregwfreedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good, i just have reservations about "cbcs-recommended".

encrypted-media-respec.html Outdated Show resolved Hide resolved
@@ -520,7 +520,7 @@


<link rel="stylesheet" href="eme.css">
<link rel="canonical" href="https://www.w3.org/TR/encrypted-media/"><style>/*
<meta name="description" content="This proposal extends [HTML] providing APIs to control playback of encrypted content."><link rel="canonical" href="https://www.w3.org/TR/encrypted-media/"><style>/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe "... providing APIs to allow playback of encrypted content."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but that's not related to this change, so let's follow-up on that separately. Thanks!

@joeyparrish joeyparrish merged commit 9deeb1a into w3c:master Dec 11, 2019
TheModMaker pushed a commit to shaka-project/shaka-player that referenced this pull request Dec 18, 2019
Note that the encryptionScheme field isn't being used by Shaka Player
yet, but that this will enable us to experiment with it ahead of the
full launch of the feature in browsers.

See also:
 - https://wicg.github.io/encrypted-media-encryption-scheme/
 - WICG/encrypted-media-encryption-scheme#13
 - w3c/encrypted-media#457

Change-Id: I9e8c2b6ce4ce3f4fe634fa4164669c69959e7fde
@joeyparrish joeyparrish added this to the V2 milestone Jul 17, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ISO Common Encryption 'cbcs' Protection Scheme
2 participants