-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add encryption scheme query support #457
Conversation
e603f64
to
7676af0
Compare
Changes based on feedback in WICG/encrypted-media-encryption-scheme#7
…encryption-scheme-query
…encryption-scheme-query
To avoid merge conflicts with other PRs. I will update all generated HTML at once later on.
Note that the encryptionScheme field isn't being used by Shaka Player yet, but that this will enable us to experiment with it ahead of the full launch of the feature in browsers. See also: - https://wicg.github.io/encrypted-media-encryption-scheme/ - WICG/encrypted-media-encryption-scheme#13 - w3c/encrypted-media#457 Change-Id: I9e8c2b6ce4ce3f4fe634fa4164669c69959e7fde
…encryption-scheme-query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looks good, i just have reservations about "cbcs-recommended".
@@ -520,7 +520,7 @@ | |||
|
|||
|
|||
<link rel="stylesheet" href="eme.css"> | |||
<link rel="canonical" href="https://www.w3.org/TR/encrypted-media/"><style>/* | |||
<meta name="description" content="This proposal extends [HTML] providing APIs to control playback of encrypted content."><link rel="canonical" href="https://www.w3.org/TR/encrypted-media/"><style>/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe "... providing APIs to allow playback of encrypted content."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but that's not related to this change, so let's follow-up on that separately. Thanks!
Note that the encryptionScheme field isn't being used by Shaka Player yet, but that this will enable us to experiment with it ahead of the full launch of the feature in browsers. See also: - https://wicg.github.io/encrypted-media-encryption-scheme/ - WICG/encrypted-media-encryption-scheme#13 - w3c/encrypted-media#457 Change-Id: I9e8c2b6ce4ce3f4fe634fa4164669c69959e7fde
Closes #391
Preview | Diff