Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] "create a sum value" behavior is undefined for CSSMathClamp type #1078

Open
cdumez opened this issue Oct 18, 2022 · 0 comments

Comments

@cdumez
Copy link

cdumez commented Oct 18, 2022

"create a sum value" behavior is undefined for CSSMathClamp type:

This section deals with many types but not CSSMathClamp. I couldn't find anywhere the spec text for what the behavior should be for a CSSMathClamp.

webkit-early-warning-system pushed a commit to cdumez/WebKit that referenced this issue Oct 19, 2022
https://bugs.webkit.org/show_bug.cgi?id=246703

Reviewed by Geoffrey Garen.

Add missing implementation for CSSMathClamp::toSumValue(). Sadly I couldn't
find the corresponding specification text for this so I filed:
- w3c/css-houdini-drafts#1078

The specification is at [1] but currently fails to mention CSSMathClamp.
However, I implemented the same behavior as Blink for interoperability.

[1] https://drafts.css-houdini.org/css-typed-om/#create-a-sum-value

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/to.tentative-expected.txt:
* Source/WebCore/css/typedom/numeric/CSSMathClamp.cpp:
(WebCore::CSSMathClamp::toSumValue const):

Canonical link: https://commits.webkit.org/255746@main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant