New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure "race-network-and-fetch-handler" is used with a fetch handler #1719

Open

yoshisatoyanagisawa wants to merge 1 commit into w3c:main from yoshisatoyanagisawa:fix2

Contributor

yoshisatoyanagisawa commented May 31, 2024 •

edited by pr-preview bot

Loading

As covered in https://github.com/WICG/service-worker-static-routing-api?tab=readme-ov-file#how-does-it-work-if-there-is-no-fetch-handler, the fetch handler must exists not only for the "fetch-handler" source but also the "race-network-and-fetch-handler" source. The "race-network-and-fetch-handler" source was not written in the last update.


          Ensure "race-network-and-fetch-handler" is used with a fetch handler

96e4795

As covered in https://github.com/WICG/service-worker-static-routing-api?tab=readme-ov-file#how-does-it-work-if-there-is-no-fetch-handler, the fetch handler must exists not only for the "fetch-handler" source but also the "race-network-and-fetch-handler" source.  The "race-network-and-fetch-handler" source was not written in the last update.

Contributor Author

yoshisatoyanagisawa commented May 31, 2024

@domenic @mkruisselbrink Will you take a look?

Thank you.

sisidovski approved these changes

View reviewed changes

Contributor

sisidovski left a comment

LGTM

domenic approved these changes

View reviewed changes

Contributor Author

yoshisatoyanagisawa commented Jun 5, 2024

Thanks Domenic for the review.
@mkruisselbrink Will you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet