Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[ci]: release artifacts #3839

Merged

Conversation

charles-cooper
Copy link
Member

What I did

fix another regression from 730679b with incorrectly setting the name of the file.

How I did it

How to verify it

see test run at https://github.com/charles-cooper/vyper/actions/runs/8178816832/job/22363615165

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.83%. Comparing base (895b38a) to head (7c4cea9).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3839      +/-   ##
==========================================
- Coverage   86.11%   85.83%   -0.29%     
==========================================
  Files          92       92              
  Lines       13915    13915              
  Branches     3067     3067              
==========================================
- Hits        11983    11944      -39     
- Misses       1495     1530      +35     
- Partials      437      441       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper merged commit 541b2e7 into vyperlang:master Mar 8, 2024
84 checks passed
@charles-cooper charles-cooper deleted the fix/upload-artifact branch March 8, 2024 05:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants