-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CreateInfo
for Event
, Fence
and Semaphore
.
#1841
Conversation
The MacOS run keeps failing on this one, but it's failing when trying to load the Vulkan library at the start of a test. I didn't change anything about the library loading process in this PR, so it's quite strange that it fails so consistently on this. I wonder what's going on. |
Now the issue also appears on Windows, and I'm even more confused. |
I've tracked it down and it seems to actually be a possible issue with all other tests except this one. All other tests use the |
Not sure if there is any real implementations for Windows or MacOS on Github actions. There is this https://github.com/humbletim/setup-vulkan-sdk which I don't know if that would provide enough? Think these platforms may have to remain build only for most tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Changelog:
Another relatively simple one.