-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(VCalendar): Add eventHandlers and slots #19568
base: master
Are you sure you want to change the base?
Conversation
blalan05
commented
Apr 9, 2024
•
edited
Loading
edited
Is there support for |
No. |
events={ props.events?.filter(e => adapter.isSameDay(e.start, day.date) || adapter.isSameDay(e.end, day.date)) } | ||
></VCalendarDay> | ||
daysInWeek.value.map((day, i) => | ||
slots.intervalDay?.({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: what's the difference between day and intervalDay slots?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
day
is the replacement for MonthDay
, and intervalDay
would be the week/day view "day". The props and display is completely different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the slot names be improved? It's not immediately clear what they do and when you should use which
day={ day } | ||
title={ day ? adapter.format(day.date, 'dayOfMonth') : 'NaN' } | ||
events={ props.events?.filter(e => adapter.isSameDay(day.date, e.start) || adapter.isSameDay(day.date, e.end)) } | ||
{ ...getPrefixedEventHandlers(attrs, ':day', () => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: I'm assuming the dynamic nature of this means that the events can't be documented in/through code? @KaelWD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could have a genPrefixedEventProps<T>(':day')
too but it would have to add every single dom event as a prop which would be a huge mess. v2 got around it by manually defining <event>:row
in the overrides file but v3 doesn't have that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah.. might need that override again
1fbea85
to
c19160d
Compare
Here is my solution for #19624 :
|
c19160d
to
4e06468
Compare
I rebased and pushed some changes |
Any news on this merge request? |
ec14823
to
fc9efaa
Compare
Need help with events and torture testing slots. |
e20cfec
to
2766105
Compare
4c970f9
to
6a3285f
Compare
Any news on this merge request? |