Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.4.7] VInfiniteScroll keep emiting load event without interval after done('empty') is called. #18895

Closed
tlserver opened this issue Dec 18, 2023 · 1 comment · Fixed by #19764, Enterprise-CMCS/cmcs-eregulations#1315 or LLotme/esp-idf#19 · May be fixed by LLotme/esp-idf#5 or LLotme/esp-idf#12
Closed

[Bug Report][3.4.7] VInfiniteScroll keep emiting load event without interval after done('empty') is called. #18895

tlserver opened this issue Dec 18, 2023 · 1 comment · Fixed by #19764, Enterprise-CMCS/cmcs-eregulations#1315 or LLotme/esp-idf#19 · May be fixed by LLotme/esp-idf#5 or LLotme/esp-idf#12
Assignees
@johnleider
Labels
C: VInfiniteScroll T: bug Functionality that does not work as intended/expected
Milestone
v3.6.x

Comments

@tlserver
Copy link

tlserver commented Dec 18, 2023 •
edited
Loading

Environment

Vuetify Version: 3.4.7
Last working version: 3.3.5
Vue Version: 3.3.4
Browsers: Chrome 119.0.0.0
OS: Windows 10

Steps to reproduce

  1. Open the Browser debugger console.
  2. Scroll to bottom for 2 times, so that "No more" is shown.
  3. The console show that infiniteLoad is continously called many many times.

Expected Behavior

When "no more" is shown, load event should not be emited or it should be emited at a configable interval.

Actual Behavior

load event is emited many many times without any delay.

Reproduction Link

https://play.vuetifyjs.com/#...
@tlserver tlserver changed the title [Bug Report][3.4.7] VInfiniteScroll still keep emits load event without interval after done('empty') is called. [Bug Report][3.4.7] VInfiniteScroll keep emiting load event without interval after done('empty') is called. Dec 18, 2023
@KaelWD
Copy link
Member

KaelWD commented Dec 18, 2023

This was supposed to be fixed in v3.3.6: #17358

@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected C: VInfiniteScroll labels Jan 14, 2024
@KaelWD KaelWD mentioned this issue Jan 14, 2024
Closed
@elkofy elkofy mentioned this issue May 7, 2024
Merged
johnleider added a commit that referenced this issue May 7, 2024
@elkofy @johnleider
fix(VInfiniteScroll): do not emit load event if status is empty (#19764)
b7a4c36 
fixes #18895

Co-authored-by: John Leider <john@vuetifyjs.com>
@johnleider johnleider self-assigned this May 7, 2024
@johnleider johnleider added this to the v3.6.x milestone May 7, 2024
@brittag brittag mentioned this issue May 28, 2024
Merged
@aniketmaurya aniketmaurya mentioned this issue May 28, 2024
Closed
@brittag brittag mentioned this issue May 31, 2024
Closed
This was referenced May 31, 2024
Closed
Closed
@aniketmaurya aniketmaurya mentioned this issue Jun 11, 2024
Closed
This was referenced Jun 11, 2024
Open
Open
@YoutacRandS-VA YoutacRandS-VA mentioned this issue Jun 19, 2024
Open
@LLotme LLotme mentioned this issue Jun 20, 2024
Merged
@aniketmaurya aniketmaurya mentioned this issue Jun 20, 2024
Closed
@aniketmaurya aniketmaurya mentioned this issue Jul 3, 2024
Closed
@aniketmaurya aniketmaurya mentioned this issue Jul 11, 2024
Closed
This was referenced Jul 16, 2024
Open
Open
@aniketmaurya aniketmaurya mentioned this issue Jul 21, 2024
Closed
@snyk-io snyk-io bot mentioned this issue Jul 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnleider johnleider

Labels
C: VInfiniteScroll T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.6.x
3 participants
@tlserver @johnleider @KaelWD