Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Support active-color prop on v-bottom-navigation similar to v-list #17042

Closed
connorhvnsen opened this issue Mar 31, 2023 · 2 comments · Fixed by #19088 or Enterprise-CMCS/cmcs-eregulations#1307 · May be fixed by Shuunen/ging#200
Closed

[Feature Request] Support active-color prop on v-bottom-navigation similar to v-list #17042

connorhvnsen opened this issue Mar 31, 2023 · 2 comments · Fixed by #19088 or Enterprise-CMCS/cmcs-eregulations#1307 · May be fixed by Shuunen/ging#200
Assignees
@yuwu9145
Labels
C: VBottomNavigation VBottomNavigation C: VBtn VBtn T: enhancement Functionality that enhances existing features
Milestone
v3.6.0 (Nebula)

Comments

@connorhvnsen
Copy link

Problem to solve

Prevents need to write model bindings on v-bottom-navigation

Proposed solution

Add a prop to v-bottom-navigation component to set the applied color when the component is in an active state.
@johnleider
Copy link
Member

Can you show me what you're trying to do?

@KaelWD
Copy link
Member

KaelWD commented Jan 22, 2024 •
edited
Loading

Sounds the same as #16686, VBtn needs baseColor like VListItem

@KaelWD KaelWD added T: enhancement Functionality that enhances existing features C: VBottomNavigation VBottomNavigation labels Jan 22, 2024
@KaelWD KaelWD added the C: VBtn VBtn label Jan 22, 2024
yuwu9145 added a commit that referenced this issue Jan 23, 2024
@yuwu9145
feat(VBtnGroup): Add baseColor prop
834fd6b 
fixes #17042
@yuwu9145 yuwu9145 mentioned this issue Jan 23, 2024
Merged
@KaelWD KaelWD added this to the v3.6.0 (Nebula) milestone Jan 23, 2024
yuwu9145 added a commit that referenced this issue Jan 25, 2024
@yuwu9145
feat(VBtnGroup/VBottomNav): Add baseColor prop
7976cd9 
fixes #17042
johnleider pushed a commit that referenced this issue Apr 8, 2024
@yuwu9145
feat(VBtnGroup/VBottomNavigation): add baseColor prop (#19088)
4e84c67 
fixes #17042
@github-actions github-actions bot closed this as completed Apr 8, 2024
@Shuunen Shuunen mentioned this issue May 21, 2024
Open
@aniketmaurya aniketmaurya mentioned this issue May 22, 2024
Closed
@brittag brittag mentioned this issue May 22, 2024
Merged
@aniketmaurya aniketmaurya mentioned this issue May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuwu9145 yuwu9145

Labels
C: VBottomNavigation VBottomNavigation C: VBtn VBtn T: enhancement Functionality that enhances existing features
Projects
None yet
Milestone
v3.6.0 (Nebula)
4 participants
@yuwu9145 @johnleider @KaelWD @connorhvnsen