Skip to content

Commit

Permalink
feat(VSelect): emit selected listIndex event (#7828)
Browse files Browse the repository at this point in the history
* docs(component): menuListIndex event added to docs

Add update:menuListIndex event to VSelect documentation in events tab

* feat(VSelect): add update:listIndex event to VSelect

update:listIndex added to VSelect to indicate when keyboard-selected item is changed

* chore(deps): bump lodash.template from 4.4.0 to 4.5.0 (#7808)

Bumps [lodash.template](https://github.com/lodash/lodash) from 4.4.0 to 4.5.0.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.4.0...4.5.0)

Signed-off-by: dependabot[bot] <support@github.com>

* chore(release): publish v2.0.0-beta.8

* docs(vue-analytics): revert autoTracking parameter

* feat(VSelect): code review updates, name unification

Unified naming in docs to use kebab-case, moved tests to VSelect dir

* feat(VSelect): event name update:listIndex -> update:list-index

Changed event name to kebab case as in vue guide
  • Loading branch information
mateuszgachowski authored and MajesticPotatoe committed Sep 12, 2019
1 parent 1ba5f82 commit b795145
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 0 deletions.
4 changes: 4 additions & 0 deletions packages/api-generator/src/helpers/variables.js
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,10 @@ const VSelect = {
name: 'update:search-input',
value: 'string',
},
{
name: 'update:list-index',
value: 'number',
},
...inputEvents,
...textEvents,
].concat(validatableEvents),
Expand Down
1 change: 1 addition & 0 deletions packages/docs/src/lang/en/components/Autocompletes.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
"click:prepend": "Components.Inputs.events['click:prepend']",
"click:prepend-inner": "Components.TextFields.events['click:prepend-inner']",
"update:error": "Mixins.Validatable.events['update:error']",
"update:list-index": "Components.Selects.events['update:list-index']",
"update:search-input": "The `search-input.sync` event"
}
}
1 change: 1 addition & 0 deletions packages/docs/src/lang/en/components/Combobox.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"click:prepend": "Components.Inputs.events['click:prepend']",
"click:prepend-inner": "Components.TextFields.events['click:prepend-inner']",
"update:error": "Mixins.Validatable.events['update:error']",
"update:list-index": "Components.Selects.events['update:list-index']",
"update:search-input": "The `search-input.sync` event"
}
}
1 change: 1 addition & 0 deletions packages/docs/src/lang/en/components/Selects.json
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@
"click:prepend-inner": "Components.TextFields.events['click:prepend-inner']",
"focus": "Emitted when component is focused",
"update:error": "Mixins.Validatable.events['update:error']",
"update:list-index": "Emitted when menu item is selected using keyboard arrows",
"update:search-input": "The `search-input.sync` event"
}
}
1 change: 1 addition & 0 deletions packages/vuetify/src/components/VSelect/VSelect.ts
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,7 @@ export default baseMixins.extend<options>().extend({
// listIndex change from menu
if (this.isMenuActive && keyCode !== keyCodes.tab) {
menu.changeListIndex(e)
this.$emit('update:list-index', menu.listIndex)
}

// If menu is not active, up and down can do
Expand Down
20 changes: 20 additions & 0 deletions packages/vuetify/src/components/VSelect/__tests__/VSelect4.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,26 @@ describe('VSelect.ts', () => {
expect(wrapper.vm.$refs.menu.listIndex).toBe(-1)
})

it('should emit listIndex event when navigated by keyboard', () => {
const wrapper = mountFunction({
propsData: {
items: ['foo', 'bar'],
},
})

const listIndexUpdate = jest.fn()
wrapper.vm.$on('update:list-index', listIndexUpdate)

const input = wrapper.find('input')
const slot = wrapper.find('.v-input__slot')
slot.trigger('click')

input.trigger('keydown.down')
expect(listIndexUpdate).toHaveBeenCalledWith(0)
input.trigger('keydown.down')
expect(listIndexUpdate).toHaveBeenCalledWith(1)
})

it('should not change value when typing on readonly field', async () => {
const wrapper = mountFunction({
propsData: {
Expand Down

0 comments on commit b795145

Please sign in to comment.