-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
es7 support #3690
es7 support #3690
Conversation
@andrzejewsky yeah, exactly this. But it should be conditional statement to support prev. Elastic versions as well |
4416e87
to
c83f000
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest just to check if total.value
doe exist or if total
is an object - we shouldn't prefferably have an additional config variable just for that
aa2a750
to
6bc5007
Compare
@pkarw done |
You havnt addressed the breaking changes issue for Elastic 7, _sourceInclude and _sourceExclude is deprecated and requires the plural form now. |
@ajsit we are still working on ES7 integration, planned to be released in Thanks for comment 👍 |
Related issues
related vuestorefront/vue-storefront-api#342
Which environment this relates to
develop
branch and want to merge it back todevelop
release
branch and want to merge it back torelease
hotfix
ormaster
branch and want to merge it back tohotfix
Upgrade Notes and Changelog
Contribution and currently important rules acceptance