Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es7 support #3690

Merged
Merged

Conversation

andrzejewsky
Copy link
Contributor

Related issues

related vuestorefront/vue-storefront-api#342

Which environment this relates to

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

@pkarw
Copy link
Collaborator

pkarw commented Oct 6, 2019

@andrzejewsky yeah, exactly this. But it should be conditional statement to support prev. Elastic versions as well

@andrzejewsky andrzejewsky marked this pull request as ready for review October 7, 2019 18:52
@andrzejewsky andrzejewsky changed the base branch from develop to release/v1.11 October 7, 2019 19:03
Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest just to check if total.value doe exist or if total is an object - we shouldn't prefferably have an additional config variable just for that

@andrzejewsky
Copy link
Contributor Author

@pkarw done

@andrzejewsky andrzejewsky merged commit f91b571 into vuestorefront:release/v1.11 Oct 10, 2019
@ajsit
Copy link

ajsit commented Nov 11, 2019

You havnt addressed the breaking changes issue for Elastic 7, _sourceInclude and _sourceExclude is deprecated and requires the plural form now.

@andrzejewsky
Copy link
Contributor Author

@ajsit we are still working on ES7 integration, planned to be released in 1.11. This PR fixes common issues that we've found, but the PR that introduces ES7 in the API has not merged yet as it requires more tests. When it comes to breaking changes - we'd like to support both ES5 and ES7 without BC-breaks for end user/developer as it could be possible so probably these name for VSF perspective will be still same - will see, otherwise we put some upgrade notes.

Thanks for comment 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants