Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use localized routes for redirects to home page and account page #2157

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

grimasod
Copy link
Contributor

Related issues

Short description and why it's useful

Some redirects were not using localized routes, which causes customers to be redirected to the default store. This commit fixes several of these cases. Specifically: (1) client-entry commonErrorHandler empty result error handler redirect to home page. (2) Account button redirect to home page on logout and account page on login. (3) Category page no result handler redirect to home page. (4) Checkout empty cart handler redirect to home page (5) CMS page no result handler redirect to home page.

Screenshots of visual changes before/after (if there are any)

Screenshot of passed e2e tests (if you are using our standard setup as a backend)

not e2e tested

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)

Contribution and currently important rules acceptance

@pkarw
Copy link
Collaborator

pkarw commented Jan 11, 2019

Thanks!

@pkarw pkarw merged commit 2afadf5 into vuestorefront:develop Jan 11, 2019
@grimasod grimasod deleted the bugfix/use-localized-routes branch July 1, 2019 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants