-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web share module + depreciations #2143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool feature:)
Only i'd left old helpers with warning and instruction to assure smooth upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the note from @patzick on extending the Upgrade notes
…efront into web-share-module
Related issues
#2099
Short description and why it's useful
I added tiny module just to have sth new in this release. Also depreciated some parts of the app that were meant to be depreciated in 1.7 (unfortunately due to 2 weeks off I wouldnt be able to depreciate everything we planned to in favour of doing performance optimisation)
Screenshots of visual changes before/after (if there are any)
(if you made any changes in the UI layer please provide before/after screenshots)
Screenshot of passed e2e tests (if you are using our standard setup as a backend)
(run
yarn test:e2e
and paste the results. If you are not using our standard backend setup or demo.vuestorefront.io you can ommit this step)Upgrade Notes and Changelog
Contribution and currently important rules acceptance