fix multiple placing order invocation after changing payment methods #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as far as I understood the problem beret was that this module supports multiple payment methods (so the event has been bound multiple times). Could you just to make sure check if the https://github.com/develodesign/vsf-payment-paypal/blob/master/hooks/beforeRegistration.ts isn’t also affected by this issue? I think it’s not a case but better be safe than sorry I’m case of payments :-) |
patzick
deleted the
bugfix/payment-method-change-causes-multiple-order-placing
branch
|
@pkarw good suggestion. I've made PR there. Now we'll be sure that nothing like this would happen there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
This resolves multiple order placing.
After each payment method change there was new place order binding, so on checkout iw was invoked multiple times.