Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1975 + #2076 #2100

Merged
merged 6 commits into from
Dec 19, 2018
Merged

#1975 + #2076 #2100

merged 6 commits into from
Dec 19, 2018

Conversation

pkarw
Copy link
Collaborator

@pkarw pkarw commented Dec 18, 2018

Related issues

(put links to related issues here)

Short description and why it's useful

@NataliaTepluhina please do add this to the docs:

Dynamic Categories prefetching (#2076)
Starting with Vue Storefront 1.7 we've added a configuration option config.entities.category.categoriesDynamicPrefetch (by default set to true). This option switches the way the category tree is being fetched. Previously we were fetching the full categories tree. In some cases it can generate even few MB of payload. Currently with this option in place we're pre-fetching the categories on demand while user is browsing the category tree

Screenshots of visual changes before/after (if there are any)

(if you made any changes in the UI layer please provide before/after screenshots)

Screenshot of passed e2e tests (if you are using our standard setup as a backend)

(run yarn test:e2e and paste the results. If you are not using our standard backend setup or demo.vuestorefront.io you can ommit this step)

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

@NataliaTepluhina please do add this to the docs:

Dynamic Categories prefetching (#2076)
Starting with Vue Storefront 1.7 we've added a configuration option `config.entities.category.categoriesDynamicPrefetch` (by default set to `true`). This option switches the way the category tree is being fetched. Previously we were fetching the full categories tree. In some cases it can generate even few MB of payload. Currently with this option in place we're pre-fetching the categories on demand while user is browsing the category tree
…into develop

# Conflicts:
#	src/themes/default/pages/Home.vue
@pkarw pkarw merged commit 2e2fb77 into vuestorefront:develop Dec 19, 2018
@pkarw
Copy link
Collaborator Author

pkarw commented Jan 11, 2019

We should add to UPGRADE NOTES also an info that currently config.products.useMagentoUrlKeys is by default set to true and therefore the categories.url_key and product.url_key fields must be set in order to navigation to work @filrak could You add it to UPGRADE NOTES before releasing new version please?

@pkarw pkarw mentioned this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant