This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
Add product attributes #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzejewsky
force-pushed
the
addAttributes
branch
from
1aee89f
to
964c90e
Compare
andrzejewsky
force-pushed
the
addAttributes
branch
from
964c90e
to
ff1b914
Compare
afirlejczyk
reviewed
Jan 21, 2020
src/adapters/magento/product.js
Outdated
| is_user_defined: o.is_user_defined, | ||
| is_comparable: o.is_comparable, | ||
| attribute_code: o.attribute_code, | ||
| slug: o.slug, |
There was a problem hiding this comment.
@andrzejewsky where 'slug' come for attribute ? I don't remember anything like that in Magento nor in VSF.
https://demo.storefrontcloud.io/api/catalog/vue_storefront_catalog/attribute/_search?
There was a problem hiding this comment.
I am not sure if we need 'entity_type_id' ?
Merged
This was referenced May 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.