This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
Fix productUrlPathMapper #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix edge case in `productUrlPathMapper` sending undefined value to -_slugify`, causing `TypeError: Cannot read property 'toString' of undefined` during indexation See https://vuestorefront.slack.com/archives/CA68P1JUF/p1560431537259500
Update config.js
lukeromanowicz
approved these changes
Jul 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indexation was throwing an error in the case where the first category of the product didn't have a name.
We now loop over categories and select the first valid one (having a name)
Original Slack conversation : https://vuestorefront.slack.com/messages/CA68P1JUF/convo/CA68P1JUF-1560431537.259500/