Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9641: v-bind object should be overridable by single bindings #9653

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

Justineo
Copy link
Member

@Justineo Justineo commented Mar 8, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@posva
Copy link
Member

posva commented Mar 8, 2019

Are you sure you are referencing the right issue on this one?

@Justineo
Copy link
Member Author

Justineo commented Mar 8, 2019

@posva Oops, wrong files. I’ll fix it ASAP.

@@ -234,7 +234,7 @@ describe('Directive v-bind', () => {
template: `<test v-bind="test" data-foo="foo" dataBar="bar"/>`,
components: {
test: {
template: '<div :data-foo="dataFoo" :data-bar="dataBar"></div>',
template: '<div>{{ dataFoo }} {{ dataBar }}</div>',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old spec passed because data-foo fell through as an attribute and coincidentally appeared in the final output. Using plain text instead to ensure we got the correct value.

@@ -45,12 +46,13 @@ export function bindObjectProps (
: data.attrs || (data.attrs = {})
}
const camelizedKey = camelize(key)
if (!(key in hash) && !(camelizedKey in hash)) {
const hyphenatedKey = hyphenate(key)
if (!(camelizedKey in hash) && !(hyphenatedKey in hash)) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to ensure both camelCased and kebab-cased keys are checked here.

@Justineo Justineo requested a review from posva March 8, 2019 13:26
@yyx990803 yyx990803 merged commit 0b57380 into vuejs:dev Mar 8, 2019
@Justineo Justineo deleted the fix-9641 branch March 9, 2019 02:09
kiku-jw pushed a commit to kiku-jw/vue that referenced this pull request Jun 18, 2019
Lostlover pushed a commit to Lostlover/vue that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants