Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#9361): appear error when using inline-template with no children #9362

Closed
wants to merge 5 commits into from
Closed

Conversation

kerm1it
Copy link

@kerm1it kerm1it commented Jan 24, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

add a dev-only warning for inline-template with no children.

@kerm1it kerm1it closed this Jan 24, 2019
@kerm1it kerm1it reopened this Jan 24, 2019
@kerm1it kerm1it changed the title add a dev-only warning for inline-template with no children(fix #9361) fix(#9361): appear error when using inline-template with no children Jan 24, 2019
@kerm1it
Copy link
Author

kerm1it commented Jan 24, 2019

@posva

@posva
Copy link
Member

posva commented Jan 24, 2019

You don't need to ping me like that. I'm already tracking activity in this repo 😄

@kerm1it
Copy link
Author

kerm1it commented Jan 24, 2019

You don't need to ping me like that. I'm already tracking activity in this repo 😄

Can you tell me why test-ssr-weex isn't passed?

@posva
Copy link
Member

posva commented Jan 24, 2019

I actually don't know, I don't work on weex

@yyx990803
Copy link
Member

Thanks for the PR, it is unnecessary to change files in packages because they are auto-generated. The only files that need to be modified are in src.

I've merged #9365 which fixes the same issue but has tests.

@yyx990803 yyx990803 closed this Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants