Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #9042, #7138: handle empty placeholder case in IE #9297

Merged
merged 3 commits into from
Feb 4, 2019
Merged

fix #9042, #7138: handle empty placeholder case in IE #9297

merged 3 commits into from
Feb 4, 2019

Conversation

nciont
Copy link
Contributor

@nciont nciont commented Jan 9, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Before this fix, the workaround for #9042 was to provide null or false value instead of empty string: :placeholder="placeholder || null".
The fix from #7138 was incomplete as it did not account for the case when placeholder attribute exists but is empty and the bug is not triggered in IE.
A new test case ensures the first triggered event does not get blocked.

@yyx990803
Copy link
Member

yyx990803 commented Feb 4, 2019

Thanks for the fix! When investigating this I also noticed that the bug actually only applies to <textarea> and not <input>... so this should fix #9383 as well

@yyx990803 yyx990803 merged commit 0fb03b7 into vuejs:dev Feb 4, 2019
Lostlover pushed a commit to Lostlover/vue that referenced this pull request Dec 10, 2019
…9297)

- the original bug in vuejs#7138 only happens for `<textarea>`
- the bug doesn't happen if placeholder has empty value

fix vuejs#9042, fix vuejs#9383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants