Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select with v-model triggers change event when its options are changed #6193

Closed
floorish opened this issue Jul 23, 2017 · 2 comments
Closed

Select with v-model triggers change event when its options are changed #6193

floorish opened this issue Jul 23, 2017 · 2 comments
Labels
regression

Comments

@floorish
Copy link

Version

2.4.2

Reproduction link

https://jsfiddle.net/floorish/e2h2vwc2/

Steps to reproduce

Dynamically change the <option>s in a <select v-model="val"> tag and the v-model triggers a change event, but the actually chosen option hasn't changed.

What is expected?

v-model does not trigger a change event

What is actually happening?

v-model triggers a change event

Change of behaviour intruduced in c90b140
@jkzing
Copy link
Member

jkzing commented Jul 23, 2017

Looks like a regression

@posva
Copy link
Member

posva commented Jul 23, 2017

The event is triggering at the beginning as well while it shouldn't

jkzing added a commit to jkzing/vue that referenced this issue Jul 23, 2017
@jkzing
feat: add failing test for vuejs#6193
7f542a9
@jkzing jkzing mentioned this issue Jul 23, 2017
Merged
13 tasks
@LinusBorg LinusBorg mentioned this issue Aug 8, 2017
Closed
yyx990803 pushed a commit that referenced this issue Aug 29, 2017
@jkzing @yyx990803
fix(v-model): avoid unnecessary change event on select options change
d4d553c 
fix #6193
via #6194
FranklinTesla pushed a commit to FranklinTesla/vue that referenced this issue Sep 5, 2017
@jkzing
fix(v-model): avoid unnecessary change event on select options change
5653702 
fix vuejs#6193
via vuejs#6194
@logaretm logaretm mentioned this issue Oct 29, 2017
Closed
ztlevi pushed a commit to ztlevi/vue that referenced this issue Feb 14, 2018
@jkzing @ztlevi
fix(v-model): avoid unnecessary change event on select options change
c69efbb 
fix vuejs#6193
via vuejs#6194
f2009 pushed a commit to f2009/vue that referenced this issue Jan 25, 2019
@jkzing
fix(v-model): avoid unnecessary change event on select options change
01da003 
fix vuejs#6193
via vuejs#6194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@floorish @posva @jkzing