Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure new webpack5 generator property in rules passes ruleset checks (v16) #1754

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

LinusBorg
Copy link
Member

@LinusBorg LinusBorg commented Oct 28, 2020

Webpack 5 has a new property in rule definitions called generator - we need to account for that in the rule validiations we have in place.

Note this is for vue-loader 16, targeting Vue 3. Matching PR for v15: #1753

Tests

I wasn't able to test this with v16, as the repo is locked to webpack v4, and switching tempararily to webpack 5 breaks everything as the type imports for webpack no longer work/match.

Since I could verify the change on the other PR for v15, this should be safe to merge.

close #1729

@LinusBorg LinusBorg changed the title fix: ensure new webpack5 generator property in rules passes ruleset checks fix: ensure new webpack5 generator property in rules passes ruleset checks (v16) Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants