Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Order of postcss modules when provided other postcss plugins #84

Open
lancetharper opened this issue Mar 6, 2019 · 2 comments
Open

Comments

@lancetharper
Copy link

lancetharper commented Mar 6, 2019

I'm using rollup-plugin-vue and noticed that if I use postcss-import (or any other postcss plugins to use as a replacement for less/sass) that the module'd class names are not added to the $style object for classes that are contained within imported stylesheets.

I believe it is because postcss-modules is prepended and run before my other supplied plugins here. I can confirm that by inverting and concat'ing the postcss modules fixes the issue for me, however I'm curious if there is a deeper reason for prepending it.

You can find my original issue here for reproduction.

I'm happy to put together a PR if no one sees any reason not to do this.

@lancetharper lancetharper changed the title Postcss modules with other postcss plugins Order of postcss modules when provided other postcss plugins Mar 6, 2019
@ztamizzen
Copy link

Any progress?

@lancetharper
Copy link
Author

@ztamizzen No response yet. I assume they've been busy with the recent Vue Conference.

The change itself would be pretty small/simple so once we get some guidance here the fix (if any) would be quick and easy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants