Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eliminate calling deprecated function in cli-plugin-e2e-cypress and cli-plugin-e2e-nightwatch #7158

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

blzsaa
Copy link
Contributor

@blzsaa blzsaa commented May 30, 2022

Due to webpack-dev-server's close() method became deprecated in version v4.0.0, currently vue-cli
is using version ^4.7.3, everytime when cli-plugin-e2e-cypress or cli-plugin-e2e-nightwatch ran any
tests a deprecation warning appeared. From now on method stop() is called instead of close() as
advised by the deprecation warning.

close #7157

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

…and cli-plugin-e2e-nightwatch

Due to webpack-dev-server's close() method became deprecated in version v4.0.0, currently vue-cli
is using version ^4.7.3, everytime when cli-plugin-e2e-cypress or cli-plugin-e2e-nightwatch ran any
tests a deprecation warning appeared. From now on method stop() is called instead of close() as
advised by the deprecation warning.

close #7157
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eliminate calling deprecated method: close() in cli-plugin-e2e-cypress and cli-plugin-e2e-nightwatch
2 participants