Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): only process template file contents, bump yaml-front-matter… #5921

Merged
merged 1 commit into from
Nov 13, 2020
Merged

fix(cli): only process template file contents, bump yaml-front-matter… #5921

merged 1 commit into from
Nov 13, 2020

Conversation

ferm10n
Copy link
Contributor

@ferm10n ferm10n commented Oct 2, 2020

… (#5920)

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

haoqunjiang
haoqunjiang approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

Without your help, I would never find out this bug by myself as I've enabled auto-inserting final newline in my editor, and a string ending with a newline is never a real file path.

@haoqunjiang haoqunjiang merged commit d355004 into vuejs:dev Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferm10n @haoqunjiang