Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark @vue/compiler-dom as optional #1958

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

cexbrayat
Copy link
Member

This should solve the pnpm error:

├─┬ @vue/test-utils 2.2.8
│ └── ✕ missing peer @vue/compiler-dom@^3.0.1

This was brought to our attention by @Shinigami92 on DIscord

This should solve the pnpm error:

```
├─┬ @vue/test-utils 2.2.8
│ └── ✕ missing peer @vue/compiler-dom@^3.0.1
```
@netlify
Copy link

netlify bot commented Jan 31, 2023

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit 05a1244
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/63d94b7b33ccdb00094cc277
😎 Deploy Preview https://deploy-preview-1958--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lmiller1990 lmiller1990 merged commit 5f574e2 into vuejs:main Feb 1, 2023
cexbrayat added a commit to cexbrayat/vue-test-utils-next that referenced this pull request May 11, 2023
We used `optionalDependencies` in vuejs#1958 but I think the proper way is to use `peerDependenciesMeta`.
This fixes the current issue where pnpm installs compiler-dom and server-renderer in v3.2.47,
despite v3.3.1 being available.
cexbrayat added a commit that referenced this pull request May 11, 2023
We used `optionalDependencies` in #1958 but I think the proper way is to use `peerDependenciesMeta`.
This fixes the current issue where pnpm installs compiler-dom and server-renderer in v3.2.47,
despite v3.3.1 being available.
stefpb added a commit to stefpb/test-utils that referenced this pull request Aug 31, 2023
Otherwise you get with yarn berry an error
@vue/test-utils tried to access @vue/compiler-dom (a peer dependency)
but it isn't provided by your application; this makes the require call
ambiguous and unsound.

May cause vuejs#1958 again. May fixes vuejs#2107.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants