Feature request: respect devtools definition

[webfansplz]

Is your feature request related to a problem? Please describe.

Hi, Team. I'm the creator of devtools-next. I want to use vuejs/test-utils to test the devtools hook. But I see that there seems to be a polyfill of devtools in the test-utils code. I wonder if it seems like we can add an option to support it? This makes sense for users who want to test the devtools hook functionality. I can submit a PR if it is feasible, thank you.

Describe the solution you'd like

export interface MountingOptions<Props, Data = {}>
  extends BaseMountingOptions<Props, Data> {
  /**
   * Specify where to mount the component.
   * Can be a valid CSS selector, or an Element connected to the document.
   * @see https://test-utils.vuejs.org/api/#attachto
   */
  attachTo?: HTMLElement | string

  /**
   * @default: true
   */
  enableDevtoolsPolyfill?: boolean
}

Describe alternatives you've considered

Additional context

[cexbrayat]

Hi @webfansplz !

IIRC we just use the COMPONENT_EMIT event to know if an event has been emitted. I don't think we are tied to an implementation of the devtools: we just subscribe to the events emitted by the framework for the devtools. But maybe I'm misunderstanding what you are looking for?

[webfansplz]

Hi @webfansplz !

IIRC we just use the COMPONENT_EMIT event to know if an event has been emitted. I don't think we are tied to an implementation of the devtools: we just subscribe to the events emitted by the framework for the devtools. But maybe I'm misunderstanding what you are looking for?

Hi @cexbrayat !

This is because calling setDevtoolsHook actually overrides the initialization of devtools. See: https://github.com/vuejs/core/blob/HEAD/packages/runtime-core/src/devtools.ts#L52-L53

[cexbrayat]

Ha OK I understand now 👍

Well TBH, I'm not a fan of adding an option to mount just to test the devtools. Maybe we can find another solution?

[webfansplz]

Ha OK I understand now 👍

Well TBH, I'm not a fan of adding an option to mount just to test the devtools. Maybe we can find another solution?

I thought maybe we could add an extra judgment, if globalThis.__VUE_DEVTOOLS_GLOBAL_HOOK__ is already defined (see: https://github.com/vuejs/core/blob/HEAD/packages/runtime-core/src/renderer.ts#L340-L341), we could implement the subscription by overriding its emit method without overwriting the original devtools definition.

[cexbrayat]

Yeah maybe that could work 👍

[webfansplz]

Yeah maybe that could work 👍

Thank you, I'll submit a PR to support it.