Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slots Unification #20

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Slots Unification #20

merged 3 commits into from
Nov 12, 2019

Conversation

yyx990803
Copy link
Member

@yyx990803 yyx990803 commented Mar 12, 2019

@yyx990803 yyx990803 added breaking change This RFC contains breaking changes or deprecations of old API. core 3.x This RFC only targets 3.0 and above labels Mar 12, 2019
@yyx990803 yyx990803 changed the title slots unification Slots Unification Mar 12, 2019
@posva
Copy link
Member

posva commented Mar 12, 2019

Is

h(Comp, () => [h('div', this.msg)])

equivalent to

h(Comp, {
  slots: {
    default: () => [h('div', this.msg)],
  },
})

in v3?

@yyx990803
Copy link
Member Author

@posva yes.

@IanSun
Copy link

IanSun commented Jul 16, 2019

Instead of using keyword $stable, why not design slot functions as computed to cache vnodes?Developers should be noted in documentation that a slot function should be defined preserved outside the render function scope.

@yyx990803 yyx990803 added the final comments This RFC is in final comments period label Nov 6, 2019
@yyx990803
Copy link
Member Author

This RFC is now in final comments stage. An RFC in final comments stage means that:

  • The core team has reviewed the feedback and reached consensus about the general direction of the RFC and believe that this RFC is a worthwhile addition to the framework.
  • Final comments stage does not mean the RFC's design details are final - we may still tweak the details as we implement it and discover new technical insights or constraints. It may even be further adjusted based on user feedback after it lands in an alpha/beta release.
  • If no major objections with solid supporting arguments have been presented after a week, the RFC will be merged and become an active RFC.

@yyx990803 yyx990803 merged commit f8d0acf into master Nov 12, 2019
@yyx990803 yyx990803 added feat: render function Only affects render function usage - can be ignored if only using templates and removed final comments This RFC is in final comments period labels Jul 1, 2020
@bencodezen bencodezen mentioned this pull request Jul 6, 2020
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x This RFC only targets 3.0 and above breaking change This RFC contains breaking changes or deprecations of old API. core feat: render function Only affects render function usage - can be ignored if only using templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants