Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(migration): transition-group (close #648) #649

Merged
merged 8 commits into from
Oct 31, 2020

Conversation

LinusBorg
Copy link
Member

@LinusBorg LinusBorg commented Oct 24, 2020

<transition-group> no longer renders a root element by default, since Vue 3 now supports fragments.

document fragment default behaviour
Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few small suggestions from me.

src/guide/migration/transition-group.md Outdated Show resolved Hide resolved
src/guide/migration/transition-group.md Outdated Show resolved Hide resolved
src/guide/migration/transition-group.md Outdated Show resolved Hide resolved
src/guide/migration/transition-group.md Outdated Show resolved Hide resolved
src/guide/migration/transition-group.md Outdated Show resolved Hide resolved
src/guide/transitions-list.md Outdated Show resolved Hide resolved
src/guide/migration/transition-group.md Show resolved Hide resolved
@LinusBorg LinusBorg self-assigned this Oct 26, 2020
@sdras
Copy link
Member

sdras commented Oct 31, 2020

This is fantastic! Thank you so much @LinusBorg and also @skirtles-code for the wonderful review

@sdras sdras merged commit 7e484c3 into master Oct 31, 2020
@sdras sdras deleted the linusborg-transition-group-wrapper-648 branch October 31, 2020 16:52
nick-lai pushed a commit to nick-lai/docs-next that referenced this pull request Dec 2, 2020
* feat(migration): transition-group
document fragment default behaviour

* Update src/guide/migration/transition-group.md

* Update src/guide/migration/transition-group.md

* Update src/guide/migration/transition-group.md

* Update src/guide/migration/transition-group.md

* Update src/guide/transitions-list.md

* Update src/guide/migration/transition-group.md

* add transition-group to config

Co-authored-by: Thorsten Luenborg <t.luneborg@googlemail.com>
Co-authored-by: Sarah Drasner <sarah.drasner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TransitionGroup doesn't render a wrapper element by default in Vue 3, it uses a Fragment
3 participants