Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8105 #8641

Closed
wants to merge 2 commits into from
Closed

Fix #8105 #8641

wants to merge 2 commits into from

Conversation

kikuchan
Copy link

Fix for #8105

@kikuchan
Copy link
Author

It also fixes nuxt/nuxt#13350 btw

@kikuchan
Copy link
Author

I'm sorry, I've found that the 1st patch was wrong. (sometimes didn't work)

This time, make the anchor selection step robust. It works perfectly, so far.

The last patch could be PoC, but it surely means the bug exists nearby.
Noticeable point is, unmount and move could trigger remove operation multiple time internally via hooks.
The anchor selection used here was not robust for this situation.

@haoqunjiang
Copy link
Member

Thanks for the PR. The mentioned issue has been fixed by #9309 and was shipped in 3.3.10.
So I'm closing this PR.

@haoqunjiang haoqunjiang closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Issue / PR Management
Status: Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kikuchan @haoqunjiang