Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: copy-paste jsx-runtime types for global JSX namespace registration #7978

Merged
merged 3 commits into from
Mar 29, 2023
Merged

fix: copy-paste jsx-runtime types for global JSX namespace registration #7978

merged 3 commits into from
Mar 29, 2023

Commits on Mar 28, 2023

  1. fix: copy-paste jsx-runtime types for global JSX namespace registration 

    Otherwise TypeScript will raise TS2322 errors. I have no idea why and
how does the fix work. But it does.

Even importing the `ReservedProps` and `NativeElements` types from
`jsx-runtime` instead of declaring them in the module would fail the
tests. I have no idea why, either.

The failing tests are at https://github.com/vuejs/ecosystem-ci/actions/runs/4538928668/jobs/7998297656#step:7:3
    @haoqunjiang
    haoqunjiang committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    e54dde1 View commit details
    Browse the repository at this point in the history

  2. fix: re-export all jsx dom types

    @haoqunjiang
    haoqunjiang committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    5d36547 View commit details
    Browse the repository at this point in the history

  3. fix: re-export in the jsx-register module

    @haoqunjiang
    haoqunjiang committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    bd45800 View commit details
    Browse the repository at this point in the history