Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): ref directly wrapped in proxy, should not track internal _value access. (fix: #6358) #6376

Conversation

lidlanca
Copy link
Contributor

@lidlanca lidlanca commented Jul 28, 2022

It need to wait for #11696 to be fixed

may fix : #6358

playground+patched


playground non patched v3.2.37
image

@lidlanca lidlanca changed the title fix(reactivity): ref directly wrapped in proxy, should not track internal _value access. fix(reactivity): ref directly wrapped in proxy, should not track internal _value access. (fix: #6358) Jul 28, 2022
@skirtles-code
Copy link
Contributor

For anyone looking to review this, I've posted a comparison with #6359 (comment) on that PR.

Copy link

github-actions bot commented Aug 23, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.6 kB 33.9 kB
vue.global.prod.js 158 kB 57.5 kB 51.2 kB

Usages

Name Size Gzip Brotli
createApp 55.1 kB 21.2 kB 19.3 kB
createSSRApp 59.1 kB 22.9 kB 20.9 kB
defineCustomElement 59.8 kB 22.7 kB 20.7 kB
overall 68.8 kB 26.3 kB 23.9 kB

Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit e4e43c8
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/66c82d42e9694a0008c43781

Copy link

pkg-pr-new bot commented Aug 23, 2024

commit: c2cd718

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@6376

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@6376

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@6376

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@6376

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@6376

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@6376

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@6376

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@6376

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@6376

vue

pnpm add https://pkg.pr.new/vue@6376

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@6376

Open in Stackblitz

@edison1105 edison1105 added the 🛑 on hold This PR can't be merged until other work is finished label Aug 28, 2024
@yyx990803 yyx990803 merged commit 1d988b5 into vuejs:main Aug 29, 2024
13 checks passed
@yyx990803
Copy link
Member

The fix is no longer needed in 3.5 after 313e4bf, but the test case is merged as it is useful to prevent future regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛑 on hold This PR can't be merged until other work is finished scope: reactivity
Projects
Development

Successfully merging this pull request may close these issues.

ref is called as a reactive parameter and effectFn is triggered multiple times when updated
5 participants