Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-sfc): should generate the correct srcset #3957

Closed
wants to merge 1 commit into from
Closed

fix(compiler-sfc): should generate the correct srcset #3957

wants to merge 1 commit into from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Jun 15, 2021 •
edited
Loading

fix #3874

@yyx990803
Copy link
Member

See 3056e9b - only need to check vnode props for the type.

I used the test from this PR though - thanks!

@yyx990803 yyx990803 closed this Jul 19, 2021
@edison1105
Copy link
Member Author

@yyx990803
oh no, you should close #3814, not this one. 😆

@edison1105 edison1105 mentioned this pull request Jul 20, 2021
Closed
@posva posva reopened this Jul 20, 2021
@ElMassimo ElMassimo mentioned this pull request Nov 12, 2021
Closed
2 tasks
@yyx990803
Copy link
Member

Should not alter default hoistStatic option - see 57bb37b

@yyx990803 yyx990803 closed this May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: sfc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@vue/server-renderer renderToString generating incorrect srcset URL for source elements within a router link
3 participants
@edison1105 @yyx990803 @posva