Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): patch suspense exit optimized mode #3831

Closed
wants to merge 2 commits into from
Closed

fix(runtime-core): patch suspense exit optimized mode #3831

wants to merge 2 commits into from

Conversation

edison1105
Copy link
Member

close #3828

@edison1105 edison1105 changed the title fix(runtime-core): patch suspense quit optimized mode fix(runtime-core): patch suspense quit optimized mode if root did not change May 26, 2021
@edison1105 edison1105 changed the title fix(runtime-core): patch suspense quit optimized mode if root did not change fix(runtime-core): patch suspense exit optimized mode May 27, 2021
@yyx990803
Copy link
Member

The root cause is that suspense slots are not rendered as normal slots with renderSlot. Normal slots are wrapped with a fragment block, but suspense slots are not (so the dynamic children tracking are lost).

See 9f24195

@yyx990803 yyx990803 closed this May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reactive ref change not propagating in suspense block
2 participants
@edison1105 @yyx990803