fix(runtime-core): ensure app instance can be garbage collected after unmount. (close #2907) #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 19, 2020 18:45
LinusBorg
changed the title
Size report
|
LinusBorg
added
🐞 bug
underfin
reviewed
Dec 29, 2020
| ? shallow | ||
| ? shallowReadonlyMap | ||
| : readonlyMap | ||
| : shallow |
There was a problem hiding this comment.
Here mixed other unrelated code.
There was a problem hiding this comment.
Ah damn. Somehow some changes meant for another branch slipped in here.
Wil fix it in a minute
|
will send a new, clean one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unmounting an app, we need to remove the
__vue_app__property from the container element, otherwise the app instance can't be garbage collected for as long as that element exists.closes #2907