Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should can re-mount after unmount #1290

Closed
wants to merge 1 commit into from
Closed

fix: should can re-mount after unmount #1290

wants to merge 1 commit into from

Conversation

underfin
Copy link
Member

@underfin underfin commented Jun 3, 2020

fix #1287

@pikax
Copy link
Member

pikax commented Jun 3, 2020

This should be closed based on #1287 (comment)

@yyx990803 yyx990803 closed this Jun 3, 2020
@underfin underfin deleted the re-mount-after-unmount branch June 4, 2020 01:08
@yyx990803
Copy link
Member

I think we can add a warning/tip when trying to re-mount an unmounted app and tell the user to move app creation into a function.

@underfin
Copy link
Member Author

underfin commented Jun 5, 2020

Yeah.Do it with #1297.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unmounted App cannot be mounted again
3 participants
@underfin @pikax @yyx990803