Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): correctly infer TypeEmits with both tuple and function syntax #11840

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

KazariEX
Copy link
Contributor

@KazariEX KazariEX commented Sep 6, 2024

fix #11836

Copy link

github-actions bot commented Sep 6, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.7 kB 34 kB
vue.global.prod.js 159 kB 57.6 kB 51.3 kB

Usages

Name Size Gzip Brotli
createApp 55.3 kB 21.3 kB 19.4 kB
createSSRApp 59.3 kB 23 kB 20.9 kB
defineCustomElement 60 kB 22.8 kB 20.7 kB
overall 69.1 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Sep 6, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11840

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11840

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11840

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11840

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11840

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11840

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11840

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11840

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11840

vue

pnpm add https://pkg.pr.new/vue@11840

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11840

commit: 1d144aa

@KazariEX KazariEX changed the title fix: correctly infer TypeEmits with both tuple and function syntax fix(runtime-core): correctly infer TypeEmits with both tuple and function syntax Sep 6, 2024
@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Sep 6, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n failure failure
vue-macros success failure
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: types labels Sep 6, 2024
zcf0508 added a commit to zcf0508/volar-defineModel-tsx that referenced this pull request Sep 6, 2024
@zcf0508
Copy link

zcf0508 commented Sep 6, 2024

I think this can't resolve the error.

https://github.com/zcf0508/volar-defineModel-tsx

image

@KazariEX
Copy link
Contributor Author

KazariEX commented Sep 6, 2024

It works on my machine.

image

@zcf0508
Copy link

zcf0508 commented Sep 6, 2024

It works on my machine.

image

I update vue-tsc from 2.1.2 to 2.1.6, and it works. Thank you.

@yyx990803 yyx990803 merged commit dad6738 into vuejs:main Sep 6, 2024
13 checks passed
@KazariEX KazariEX deleted the fix/typeEmits branch September 6, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged. scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The emits from defineModel are missing in tsx file
5 participants