perf(effect): optimize effect trigger for array length mutation (#761)

vuejs · Feb 22, 2020 · 76c7f54 · 76c7f54
1 parent e9024bf
commit 76c7f54
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/packages/reactivity/src/effect.ts b/packages/reactivity/src/effect.ts
@@ -176,17 +176,18 @@ export function trigger(
   }
   const effects = new Set<ReactiveEffect>()
   const computedRunners = new Set<ReactiveEffect>()
-  if (
-    type === TriggerOpTypes.CLEAR ||
-    (key === 'length' &&
-      isArray(target) &&
-      (newValue as number) < (oldValue as number))
-  ) {
-    // collection being cleared or Array length mutation
+  if (type === TriggerOpTypes.CLEAR) {
+    // collection being cleared
     // trigger all effects for target
     depsMap.forEach(dep => {
       addRunners(effects, computedRunners, dep)
     })
+  } else if (key === 'length' && isArray(target)) {
+    depsMap.forEach((dep, key) => {
+      if (key === 'length' || key >= (newValue as number)) {
+        addRunners(effects, computedRunners, dep)
+      }
+    })
   } else {
     // schedule runs for SET | ADD | DELETE
     if (key !== void 0) {