Feat: Adds generated-at metatag to identify build time #2417

emersonlaurentino · 2024-08-19T14:42:36Z

What's the purpose of this pull request?

create a metatag in build time in order to know when the build was created.

How it works?

using the faststore cli we generate a date and insert on store html

How to test it?

finding the generated-at metatag on source code.

Starters Deploy Preview

References

vercel · 2024-08-19T14:42:39Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
faststore-site	⬜️ Ignored (Inspect)	Visit Preview		Aug 22, 2024 6:48pm

mateuspontes

That's good!
It's important to map the generated at time for better debugging during crises and incidents, like the one we experienced on Aug 15. 🚀

eduardoformiga

The code looks good, but I'll wait to test it afterward and approve :)

eduardoformiga · 2024-08-19T15:53:47Z

packages/cli/src/utils/commands.ts


 // Retrieves the package manager based on the developer lockfile, using `ni`.
 export function getPreferredPackageManager() {
-  const agent = spawnSync("na", ['\?'], { encoding: 'utf8', shell: true }).stdout.trim()
+  const agent = spawnSync('na', ['?'], {


Is the \ removal intentional?

eduardoformiga · 2024-08-19T15:58:19Z

packages/core/next-seo.config.ts

Is this file adding the default additionalMetaTags to all places with NextSeo, right?

packages/core/tsconfig.json

codesandbox-ci · 2024-08-19T19:59:10Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

hellofanny · 2024-08-20T01:20:46Z

question: I tried looking for the tag in the starter, but I couldn't find it in the preview link. Was I supposed to find it there?

emersonlaurentino · 2024-08-20T16:00:23Z

question: I tried looking for the tag in the vtex-sites/starter.store#510, but I couldn't find it in the preview link. Was I supposed to find it there?

@hellofanny After the build error was fixed, the preview shows the tag?

hellofanny · 2024-08-20T18:15:01Z

question: I tried looking for the tag in the vtex-sites/starter.store#510, but I couldn't find it in the preview link. Was I supposed to find it there?

@hellofanny After the build error was fixed, the preview shows the tag?

@emersonlaurentino I couldn't see

question: I tried looking for the tag in the vtex-sites/starter.store#510, but I couldn't find it in the preview link. Was I supposed to find it there?

@hellofanny After the build error was fixed, the preview shows the tag?

@emersonlaurentino I've searched again and still couldn't find it

emersonlaurentino · 2024-08-20T18:59:52Z

question: I tried looking for the tag in the vtex-sites/starter.store#510, but I couldn't find it in the preview link. Was I supposed to find it there?

@hellofanny After the build error was fixed, the preview shows the tag?

@emersonlaurentino I couldn't see

question: I tried looking for the tag in the vtex-sites/starter.store#510, but I couldn't find it in the preview link. Was I supposed to find it there?

@hellofanny After the build error was fixed, the preview shows the tag?

@emersonlaurentino I've searched again and still couldn't find it

Okay, I'll fix it

…ta-generated-at'

emersonlaurentino · 2024-08-22T18:50:28Z

packages/core/src/pages/_app.tsx

hellofanny

Tag with build time info testing in this preview 🚀

#2417 follow-up. Adds generated-at metatag on source code to identify when the build was created.

## What's the purpose of this pull request? Using the next metadata to define the SEO tags. |before: NextSeo | After: fs-next-update | |-|-| |<img width="513" alt="image" src="https://github.com/user-attachments/assets/bdeef211-d9eb-4fb8-9015-7566eb9c1659">|<img width="468" alt="image" src="https://github.com/user-attachments/assets/7c66bbea-9e1a-4cc8-81b7-1a24bc79c971">| todo: - [ ] check duplicate tags related issue: vercel/next.js#63489 It didn't work for me, I couldn't fix it :/ - [ ] after updating the `feat/next-13` branch with `main`, we need to consider #2417 changes Regarding the JSON-LD, I added it as recommended in the [documentation](https://nextjs.org/docs/app/building-your-application/optimizing/metadata#json-ld): by rendering the structured data as a <script> tag. I've checked that the generated schema was the same as before and still valid. <img width="1520" alt="image" src="https://github.com/user-attachments/assets/2c01efd0-0110-43c5-b95c-655e24cf0167"> |before: SiteLinksSearchBoxJsonLd | After: fs-next-update | |-|-| |<img width="909" alt="image" src="https://github.com/user-attachments/assets/fda08173-3efa-4317-ab50-d52ca8e640c4">|<img width="916" alt="image" src="https://github.com/user-attachments/assets/a1b2af2e-bf53-4a61-9333-c16ba7ffd76b">| **Question/Curiosity**: Does anyone know how this is being used? ## How to test it? Navigate to packages/core, run `yarn dev` **Metatags** 1. Open the [homepage](https://starter.vtex.app/) and inspect the page, if using chrome, in the `Elements` tab, search for `meta`. 2. In another tab open the homepage: localhost:3000/fs-next-update , do the same. Inspect and search for `meta`. Compare the tags, you should be able to see all the tags in the stater here. ___ **JsonLd** 1. Open the [homepage](https://starter.vtex.app/) and inspect the page, if using chrome, in the `Elements` tab, search for `SearchAction`. <img width="200" alt="image" src="https://github.com/user-attachments/assets/9ee2f3d8-cbb4-4183-a979-cc49ece55194"> 2. In another tab open the homepage: localhost:3000/fs-next-update , do the same. Inspect and search for `SearchAction`. Compare the script, it should the same. ## References - [SFS 815](https://vtex-dev.atlassian.net/browse/SFS-815?atlOrigin=eyJpIjoiZDMxYTJjYzY0MWZiNDAxZjllYWM1YTVkYWJmMmQ3MjEiLCJwIjoiaiJ9) - [Nextjs Optimizing Metadata]( https://nextjs.org/docs/app/building-your-application/optimizing/metadata)

emersonlaurentino self-assigned this Aug 19, 2024

emersonlaurentino requested a review from a team as a code owner August 19, 2024 14:42

emersonlaurentino requested review from renatamottam and lucasfp13 and removed request for a team August 19, 2024 14:42

emersonlaurentino requested review from hellofanny and removed request for renatamottam August 19, 2024 14:44

mateuspontes approved these changes Aug 19, 2024

View reviewed changes

eduardoformiga reviewed Aug 19, 2024

View reviewed changes

hellofanny mentioned this pull request Aug 19, 2024

feat: Adds build generated metatag vtex-sites/starter.store#510

Closed

emersonlaurentino added 3 commits August 22, 2024 09:48

generated at

4113686

chore: remove console.log statement in build command

f38c7a0

chore: Update tsconfig.json include paths

5254323

emersonlaurentino force-pushed the feat-generated branch from 212cf35 to 5254323 Compare August 22, 2024 12:48

vercel bot deployed to Preview August 22, 2024 12:54 View deployment

emersonlaurentino added 2 commits August 22, 2024 15:46

chore: Update tsconfig.json include paths

98f5bb9

chore: Update next-seo.config.ts to use 'generated-at' instead of 'da…

7742689

…ta-generated-at'

hellofanny reviewed Aug 22, 2024

View reviewed changes

packages/core/src/pages/_app.tsx Show resolved Hide resolved

hellofanny approved these changes Aug 22, 2024

View reviewed changes

emersonlaurentino merged commit 44234ba into main Aug 22, 2024
7 checks passed

emersonlaurentino deleted the feat-generated branch August 22, 2024 19:22

hellofanny mentioned this pull request Aug 23, 2024

release: FastStore core v3.0.94 #2421

Merged

hellofanny added a commit that referenced this pull request Aug 23, 2024

release: FastStore core v3.0.94 (#2421)

a548fc5

#2417 follow-up. Adds generated-at metatag on source code to identify when the build was created.

hellofanny changed the title ~~metatag generated at~~ Feat: Adds generated-at metatag to identify build time Aug 23, 2024

emersonlaurentino mentioned this pull request Sep 10, 2024

Feat: Migrating from next/head to built in SEO (metadata) #2425

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Adds generated-at metatag to identify build time #2417

Feat: Adds generated-at metatag to identify build time #2417

emersonlaurentino commented Aug 19, 2024 •

edited by hellofanny

Loading

vercel bot commented Aug 19, 2024 •

edited

Loading

mateuspontes left a comment

eduardoformiga left a comment

eduardoformiga Aug 19, 2024 •

edited

Loading

eduardoformiga Aug 19, 2024 •

edited

Loading

codesandbox-ci bot commented Aug 19, 2024 •

edited

Loading

hellofanny commented Aug 20, 2024

emersonlaurentino commented Aug 20, 2024 •

edited

Loading

hellofanny commented Aug 20, 2024

emersonlaurentino commented Aug 20, 2024

emersonlaurentino commented Aug 22, 2024

hellofanny left a comment

Feat: Adds generated-at metatag to identify build time #2417

Feat: Adds generated-at metatag to identify build time #2417

Conversation

emersonlaurentino commented Aug 19, 2024 • edited by hellofanny Loading

What's the purpose of this pull request?

How it works?

How to test it?

Starters Deploy Preview

References

vercel bot commented Aug 19, 2024 • edited Loading

mateuspontes left a comment

Choose a reason for hiding this comment

eduardoformiga left a comment

Choose a reason for hiding this comment

eduardoformiga Aug 19, 2024 • edited Loading

Choose a reason for hiding this comment

eduardoformiga Aug 19, 2024 • edited Loading

Choose a reason for hiding this comment

codesandbox-ci bot commented Aug 19, 2024 • edited Loading

hellofanny commented Aug 20, 2024

emersonlaurentino commented Aug 20, 2024 • edited Loading

hellofanny commented Aug 20, 2024

emersonlaurentino commented Aug 20, 2024

emersonlaurentino commented Aug 22, 2024

hellofanny left a comment

Choose a reason for hiding this comment

emersonlaurentino commented Aug 19, 2024 •

edited by hellofanny

Loading

vercel bot commented Aug 19, 2024 •

edited

Loading

eduardoformiga Aug 19, 2024 •

edited

Loading

eduardoformiga Aug 19, 2024 •

edited

Loading

codesandbox-ci bot commented Aug 19, 2024 •

edited

Loading

emersonlaurentino commented Aug 20, 2024 •

edited

Loading