Merge pull request #1 from vtex/fix/error-handling

Fix/error handling
vtex · Sep 18, 2018 · c4e5a4c · c4e5a4c
2 parents 422a39f + fe9cf68
commit c4e5a4c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -32,6 +32,13 @@ module.exports = function (zipPath, opts, cb) {
 
       var cancelled = false
 
+      zipfile.on('error', function (err) {
+        if (err) {
+          cancelled = true
+          return cb(err)
+        }
+      })
+
       zipfile.readEntry()
 
       zipfile.on('close', function () {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
-  "name": "extract-zip",
-  "version": "1.6.7",
+  "name": "@vtex/extract-zip",
+  "version": "1.7.0",
   "description": "unzip a zip file into a directory using 100% javascript",
   "main": "index.js",
   "bin": {

diff --git a/readme.md b/readme.md
@@ -1,3 +1,7 @@
+# Fork motivation
+
+We forked this project in order to solve an error handling issue that was pending for several months in the original project. See [this PR in `builder-hub`](https://github.com/vtex/builder-hub/pull/216) for context.
+
 # extract-zip
 
 Unzip written in pure JavaScript. Extracts a zip into a directory. Available as a library or a command line program.