Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ~/.docker to the custom image #6

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

jkeech
Copy link

@jkeech jkeech commented Mar 29, 2022

This sets up the state to verify the fix for https://github.com/github/codespaces/issues/7185 where a pre-existing ~/.docker folder should not interfere with our ability to properly symlink docker config inside the container.

@jkeech jkeech marked this pull request as ready for review March 29, 2022 04:16
@jkeech
Copy link
Author

jkeech commented Mar 29, 2022

PR for the related agent change that fixes the bug that this test data surfaces: https://dev.azure.com/devdiv/DevDiv/_git/Cascade/pullrequest/389274.

I've verified that old agent code fails with this PR's change and the new agent change passes, so this is working properly as a regression test.

@jkeech jkeech merged commit c5ad166 into devcontainer Mar 29, 2022
@jkeech jkeech deleted the jkeech/docker-config-in-devcontainer branch March 29, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant