Apply remaining cmake fixes #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles on Linux x86_64 Followup for vsg-dev#71
There is no such directory 'CMakeModules' in the source tree.
The PROJECT_ variables provided by cmake are a better replacement for these custom variables.
rhabacker
changed the title
The OpenThreads module is included by default and does not need to be explicitly specified. Added from vsg-dev#71
2 tasks
|
There is on thing left from #70, related to OSG_PLUGINS_DIRECTORY. I'm working on this |
Should be complete now. |
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup for #71
I found a few more things to simplify.