Merge pull request #3 from zaneb/lint

Add lint checks
vrutkovs · Feb 21, 2022 · d14efb8 · d14efb8
2 parents a2d7431 + bb7a691
commit d14efb8
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/data/data/agent/embed.go b/data/data/agent/embed.go
@@ -2,5 +2,6 @@ package agent
 
 import "embed"
 
+// IgnitionData contains the source data for building the ignition file
 //go:embed *
 var IgnitionData embed.FS
diff --git a/pkg/agent/imagebuilder/content.go b/pkg/agent/imagebuilder/content.go
@@ -14,9 +14,11 @@ import (
 	data "github.com/openshift-agent-team/fleeting/data/data/agent"
 )
 
+// ConfigBuilder builds an Ignition config
 type ConfigBuilder struct {
 }
 
+// Ignition builds an ignition file and returns the bytes
 func (c ConfigBuilder) Ignition() ([]byte, error) {
 	var err error
 

diff --git a/pkg/agent/imagebuilder/embed_ignition.go b/pkg/agent/imagebuilder/embed_ignition.go
@@ -11,6 +11,8 @@ const (
 	outputImage = "output/fleeting.iso"
 )
 
+// BuildImage builds an ISO with ignition content from a base image, and writes
+// the result to disk.
 func BuildImage(baseImage string) error {
 	ignition, err := ConfigBuilder{}.Ignition()
 	if err != nil {

diff --git a/pkg/agent/isosource/download.go b/pkg/agent/isosource/download.go
@@ -14,12 +14,12 @@ import (
 const (
 	outputFile = "output/coreos.iso"
 
-	isoUrl    = "https://rhcos-redirector.apps.art.xq1c.p1.openshiftapps.com/art/storage/releases/rhcos-4.10/410.84.202201251210-0/x86_64/rhcos-410.84.202201251210-0-live.x86_64.iso"
+	isoURL    = "https://rhcos-redirector.apps.art.xq1c.p1.openshiftapps.com/art/storage/releases/rhcos-4.10/410.84.202201251210-0/x86_64/rhcos-410.84.202201251210-0-live.x86_64.iso"
 	isoSha256 = "2905c1f0d85739e8600e8816c0d32711fb4002be4f845e0b20eeab35314e5b58"
 )
 
 func downloadIso(dest string) error {
-	resp, err := http.Get(isoUrl)
+	resp, err := http.Get(isoURL)
 	if err != nil {
 		return err
 	}
@@ -59,6 +59,7 @@ func haveValidIso(location string) bool {
 	return bytes.Equal(hash.Sum(nil), expectedChecksum)
 }
 
+// EnsureIso downloads the ISO if it is not already present
 func EnsureIso() (string, error) {
 	if !haveValidIso(outputFile) {
 		if err := downloadIso(outputFile); err != nil {