Initial check to see if adding url field breaks things. #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #827 +/- ##
========================================
- Coverage 97.8% 97.8% -0.1%
========================================
Files 168 168
Lines 3261 3259 -2
Branches 800 800
========================================
- Hits 3191 3189 -2
Misses 46 46
Partials 24 24 ☔ View full report in Codecov by Sentry. |
purva-thakre
reviewed
Oct 5, 2024
docs/refs.bib
Outdated
Comment on lines
8
to
10
| howpublished={https://www.scottaaronson.com/qclec/6.pdf}, | ||
| url={https://www.scottaaronson.com/qclec/6.pdf} | ||
| } |
There was a problem hiding this comment.
As the url is working, you should get rid of the howpublished entries. Otherwise, the URL shows up twice.
There was a problem hiding this comment.
That's a good point. I'll go ahead and remove the howpublished field where appropriate then. Good catch!
There was a problem hiding this comment.
I think one of the links might have to remain as howpublished.
https://github.com/vprusso/toqito/actions/runs/11193184144/job/31118220715?pr=827#step:5:1320
purva-thakre
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #275