Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing '*' with '@' where appropriate. #797

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Conversation

vprusso
Copy link
Owner

@vprusso vprusso commented Sep 20, 2024

  • Replacing * operator with @ operator for matrix or vector multiplications.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.8%. Comparing base (2f0ee8e) to head (9efac06).
Report is 6 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #797   +/-   ##
======================================
  Coverage    97.8%   97.8%           
======================================
  Files         166     166           
  Lines        3242    3242           
  Branches      794     794           
======================================
  Hits         3172    3172           
  Misses         46      46           
  Partials       24      24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@purva-thakre purva-thakre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think you missed 1 *.

one_vec = np.ones((lfac_size, 2), dtype=int) * [num[0], num[j]]

@vprusso
Copy link
Owner Author

vprusso commented Oct 2, 2024

LGTM! I think you missed 1 *.

one_vec = np.ones((lfac_size, 2), dtype=int) * [num[0], num[j]]

As it happens, this needs to be * over @, but good catch!

@vprusso vprusso merged commit bb99b3d into master Oct 2, 2024
18 checks passed
@vprusso vprusso deleted the 678-infix-vector-mat-mult branch October 2, 2024 14:43
@purva-thakre
Copy link
Collaborator

I don't think this fixed all the warnings. Just noticed a couple more:

https://github.com/vprusso/toqito/actions/runs/11151893975/job/30996320621?pr=821#step:5:3446

Should we create a new issue for these warnings?

@vprusso
Copy link
Owner Author

vprusso commented Oct 2, 2024

I don't think this fixed all the warnings. Just noticed a couple more:

https://github.com/vprusso/toqito/actions/runs/11151893975/job/30996320621?pr=821#step:5:3446

Should we create a new issue for these warnings?

Not sure if it's just me, but that link seems to freeze and not render any of the warnings that you might be seeing. If you see them though, definitely copy/paste them and create a separate issue as they should definitely be addressed. Thanks, @purva-thakre

@purva-thakre
Copy link
Collaborator

You have to reload the page or scroll down to line 3446.

The output is big which is why I think ut's not rendering anything for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants