-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matrix_props
: Check if stochastic or doubly stochastic
#723
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #723 +/- ##
======================================
Coverage 97.7% 97.7%
======================================
Files 166 167 +1
Lines 3250 3252 +2
Branches 795 795
======================================
+ Hits 3177 3179 +2
Misses 48 48
Partials 25 25 ☔ View full report in Codecov by Sentry. |
@vprusso I am confused as to why the coverage report shows a line uncovered by unit tests in all 3 functions. |
e80c329
to
6c3e039
Compare
Looks like there are still some uncovered cases from the coverage report here: |
@vprusso Yes, I brought this up in a previous comment. The lines should not show up as uncovered but they do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work, @purva-thakre !
Description
Fixes #559
Fixes #560
Changes
Notable changes that this PR has either accomplished or will accomplish. Feel free to add more lines to the itemized list
below.
is_stochastic
function, this PR adds anis_right_stochastic
and anis_left_stochastic
function as the Wikipedia definitions make sure to distinguish the two. For 1 def, the rows should sum up to 1 while in the other, the columns should sum up to 1.is_doubly_stochastic
function for the cases when a matrix is both right and left stochastic.Checklist
Before marking your PR ready for review, make sure you checked the following locally. If this is your first PR, you might be notified of some workflow failures after a maintainer has approved the workflow jobs to be run on your PR.
Additional information is available in the documentation.
ruff
for errors related to code style and formatting.pytest
.Sphinx
build can be checked locally for any failures related to your PRlinkcheck
to check for broken links in the documentationdoctest
to verify the examples in the function docstrings work as expected.